Changeset 109067 in webkit

Timestamp:

Feb 27, 2012 8:17:32 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
​https://bugs.webkit.org/show_bug.cgi?id=79622

For ease of maintainability, this patch reorders attributes and methods declaration
matching with specification.

Patch by Yoshifumi Inoue <​yosin@chromium.org> on 2012-02-27
Reviewed by Adam Barth.

No new tests. No behavior change.

• html/HTMLInputElement.idl: Reorder and remove obsolete comments.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLInputElement.idl (modified) (9 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-27  Yoshifumi Inoue  <yosin@chromium.org>
+
+        [Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
+        https://bugs.webkit.org/show_bug.cgi?id=79622
+
+        For ease of maintainability, this patch reorders attributes and methods declaration
+        matching with specification.
+
+        Reviewed by Adam Barth.
+
+        No new tests. No behavior change.
+
+        * html/HTMLInputElement.idl: Reorder and remove obsolete comments.
+
 2012-02-27  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/html/HTMLInputElement.idl

@@ -22 +22 @@
 
     interface HTMLInputElement : HTMLElement {
-        attribute [TreatNullAs=NullString] DOMString defaultValue;
+        attribute [Reflect] DOMString accept;
+        attribute [Reflect] DOMString alt;
+        attribute [Reflect] DOMString autocomplete;
+        attribute [Reflect] boolean autofocus;
         attribute [Reflect=checked] boolean defaultChecked;
+        attribute boolean checked;
         attribute [Reflect] DOMString dirName;
+        attribute [Reflect] boolean disabled;
         readonly attribute HTMLFormElement form;
+        readonly attribute FileList files;
         attribute [Reflect, URL] DOMString formAction;
         attribute [TreatNullAs=NullString] DOMString formEnctype;
@@ -31 +37 @@
         attribute [Reflect] boolean formNoValidate;
         attribute [Reflect] DOMString formTarget;
-        readonly attribute ValidityState validity;
-        attribute [Reflect] DOMString accept;
-        attribute [Reflect] DOMString align;
-        attribute [Reflect] DOMString alt;
-        attribute boolean checked;
-        attribute [Reflect] boolean disabled;
-        attribute [Reflect] boolean autofocus;
-        attribute [Reflect] DOMString autocomplete;
+        attribute boolean indeterminate;
         readonly attribute [Conditional=DATALIST] HTMLElement list;
         attribute [Reflect] DOMString max;
@@ -44 +43 @@
         attribute [Reflect] DOMString min;
         attribute [Reflect] boolean multiple;
-        attribute [Conditional=DIRECTORY_UPLOAD, Reflect] boolean webkitdirectory;
         attribute [Reflect] DOMString name;
         attribute [Reflect] DOMString pattern;
@@ -51 +49 @@
         attribute [Reflect] boolean required;
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
-        attribute [Reflect] DOMString accessKey;
         attribute [ObjCImplementedAsUnsignedLong] DOMString size; // DOM level 2 changed this to a long, but ObjC API is a string
 #else
@@ -59 +56 @@
         attribute [Reflect] DOMString step;
         attribute [TreatNullAs=NullString] DOMString type; // readonly dropped as part of DOM level 2
-        attribute [Reflect] DOMString useMap;
+        attribute [TreatNullAs=NullString] DOMString defaultValue;
         attribute [TreatNullAs=NullString] DOMString value;
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
@@ -65 +62 @@
 #endif
         attribute double valueAsNumber setter raises(DOMException);
-        readonly attribute [Conditional=DATALIST] HTMLOptionElement selectedOption;
-        attribute [Reflect] boolean incremental;
 
         void stepUp(in [Optional] long n) raises(DOMException);
@@ -72 +67 @@
 
         readonly attribute boolean willValidate;
+        readonly attribute ValidityState validity;
         readonly attribute DOMString validationMessage;
         boolean checkValidity();
         void setCustomValidity(in [TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString error);
+
+        readonly attribute NodeList labels;
+
         void select();
+        attribute [Custom] long selectionStart;
+        attribute [Custom] long selectionEnd;
+        attribute [Custom] DOMString selectionDirection;
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
+        [Custom] void setSelectionRange(in long start, in long end);
+#else
+        [Custom] void setSelectionRange(in [Optional=DefaultIsUndefined] long start, 
+                                        in [Optional=DefaultIsUndefined] long end, 
+                                        in [Optional] DOMString direction);
+#endif
+
+        // Non-standard attributes
+        attribute [Reflect] DOMString align;
+        attribute [Conditional=DIRECTORY_UPLOAD, Reflect] boolean webkitdirectory;
+        attribute [Reflect] DOMString useMap;
+        readonly attribute [Conditional=DATALIST] HTMLOptionElement selectedOption;
+        attribute [Reflect] boolean incremental;
+        attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitSpeech;
+        attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitGrammar;
+        attribute [Conditional=INPUT_SPEECH, NotEnumerable] EventListener onwebkitspeechchange;
+
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
+        attribute [Reflect] DOMString accessKey;
+#endif
 
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
@@ -85 +108 @@
 #endif
 
-        // WinIE extension:
-        attribute boolean indeterminate;
-
-        attribute [Custom] long selectionStart;
-        attribute [Custom] long selectionEnd;
-        attribute [Custom] DOMString selectionDirection;
-
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
-        [Custom] void setSelectionRange(in long start, in long end);
-#else
-        [Custom] void setSelectionRange(in [Optional=DefaultIsUndefined] long start, 
-                                        in [Optional=DefaultIsUndefined] long end, 
-                                        in [Optional] DOMString direction);
-#endif
-
-#if defined(LANGUAGE_OBJECTIVE_C)
         // Objective-C extension:
         readonly attribute DOMString altDisplayString;
@@ -106 +114 @@
 #endif
 
-        readonly attribute FileList files;
-        readonly attribute NodeList labels;
-
-        attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitSpeech;
-        attribute [Conditional=INPUT_SPEECH, Reflect, V8EnabledAtRuntime] boolean webkitGrammar;
-        attribute [Conditional=INPUT_SPEECH, NotEnumerable] EventListener onwebkitspeechchange;
     };
-
 }