Changeset 109068 in webkit


Ignore:
Timestamp:
Feb 27, 2012 8:41:18 PM (12 years ago)
Author:
abarth@webkit.org
Message:

EventFactory.in should be named EventNames.in
​https://bugs.webkit.org/show_bug.cgi?id=79727

Reviewed by Kentaro Hara.

Originally EventFactory.in was just used to generate EventFactory.cpp,
but now we're able to generate a bunch of other Event-related code from
this "in" file.

In writing some documentation about how to use these mechanisms, the
name EventFactory.in didn't seem like the right name. This patch
renames EventFactory.in to EventNames.in, which more accurately
describes the role of this file (and matches the naming convention of
HTMLTagNames.in).

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_makenames.py:

(main):

  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
  • dom/EventFactory.in: Removed.
Location:
trunk/Source/WebCore
Files:
8 edited
1 moved

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r109031 r109068  
    24492449
    24502450
    2451 GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventFactory.in EventFactory.cpp)
     2451GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventNames.in EventFactory.cpp)
    24522452LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/EventFactory.cpp)
    24532453

  • trunk/Source/WebCore/ChangeLog

    r109067 r109068  
     12012-02-27  Adam Barth  <abarth@webkit.org>
     2
     3        EventFactory.in should be named EventNames.in
     4        https://bugs.webkit.org/show_bug.cgi?id=79727
     5
     6        Reviewed by Kentaro Hara.
     7
     8        Originally EventFactory.in was just used to generate EventFactory.cpp,
     9        but now we're able to generate a bunch of other Event-related code from
     10        this "in" file.
     11
     12        In writing some documentation about how to use these mechanisms, the
     13        name EventFactory.in didn't seem like the right name.  This patch
     14        renames EventFactory.in to EventNames.in, which more accurately
     15        describes the role of this file (and matches the naming convention of
     16        HTMLTagNames.in).
     17
     18        * CMakeLists.txt:
     19        * DerivedSources.make:
     20        * DerivedSources.pri:
     21        * GNUmakefile.am:
     22        * WebCore.gyp/WebCore.gyp:
     23        * WebCore.gyp/scripts/action_makenames.py:
     24        (main):
     25        * WebCore.xcodeproj/project.pbxproj:
     26        * dom/EventNames.in: Copied from Source/WebCore/dom/EventFactory.in.
     27        * dom/EventFactory.in: Removed.
     28
    1292012-02-27  Yoshifumi Inoue  <yosin@chromium.org>
    230

  • trunk/Source/WebCore/DerivedSources.make

    r109036 r109068  
    867867# Register event constructors and targets
    868868
    869 EventFactory.cpp EventHeaders.h EventInterfaces.h : dom/make_event_factory.pl dom/EventFactory.in
    870         perl -I $(WebCore)/bindings/scripts $< --input $(WebCore)/dom/EventFactory.in
     869EventFactory.cpp EventHeaders.h EventInterfaces.h : dom/make_event_factory.pl dom/EventNames.in
     870        perl -I $(WebCore)/bindings/scripts $< --input $(WebCore)/dom/EventNames.in
    871871
    872872EventTargetHeaders.h EventTargetInterfaces.h : dom/make_event_factory.pl dom/EventTargetFactory.in

  • trunk/Source/WebCore/DerivedSources.pri

    r109036 r109068  
    4444HTML_ENTITIES = $$PWD/html/parser/HTMLEntityNames.in
    4545
    46 EVENT_FACTORY = $$PWD/dom/EventFactory.in
     46EVENTS_NAMES = $$PWD/dom/EventNames.in
    4747
    4848EVENT_TARGET_FACTORY = $$PWD/dom/EventTargetFactory.in
    … …  
    816816# GENERATOR 5-E:
    817817eventfactory.output = EventFactory.cpp
    818 eventfactory.input = EVENT_FACTORY
     818eventfactory.input = EVENTS_NAMES
    819819eventfactory.script = $$PWD/dom/make_event_factory.pl
    820 eventfactory.commands = perl -I$$PWD/bindings/scripts $$eventfactory.script --input $$EVENT_FACTORY --outputDir ${QMAKE_FUNC_FILE_OUT_PATH}
    821 eventfactory.depends = $$PWD/dom/make_event_factory.pl $$EVENT_FACTORY
     820eventfactory.commands = perl -I$$PWD/bindings/scripts $$eventfactory.script --input $$EVENTS_NAMES --outputDir ${QMAKE_FUNC_FILE_OUT_PATH}
     821eventfactory.depends = $$PWD/dom/make_event_factory.pl $$EVENTS_NAMES
    822822GENERATORS += eventfactory
    823823

  • trunk/Source/WebCore/GNUmakefile.am

    r109036 r109068  
    721721        $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --attrs $(WebCore)/xml/xmlattrs.in --outputDir "$(GENSOURCES_WEBCORE)"
    722722
    723 DerivedSources/WebCore/EventFactory.cpp DerivedSources/WebCore/EventHeaders.h DerivedSources/WebCore/EventInterfaces.h: $(WebCore)/dom/make_event_factory.pl $(WebCore)/dom/EventFactory.in
    724         $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --input $(WebCore)/dom/EventFactory.in --outputDir "$(GENSOURCES_WEBCORE)"
     723DerivedSources/WebCore/EventFactory.cpp DerivedSources/WebCore/EventHeaders.h DerivedSources/WebCore/EventInterfaces.h: $(WebCore)/dom/make_event_factory.pl $(WebCore)/dom/EventNames.in
     724        $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --input $(WebCore)/dom/EventNames.in --outputDir "$(GENSOURCES_WEBCORE)"
    725725
    726726DerivedSources/WebCore/EventTargetHeaders.h DerivedSources/WebCore/EventTargetInterfaces.h: $(WebCore)/dom/make_event_factory.pl $(WebCore)/dom/EventTargetFactory.in
    … …  
    959959        Source/WebCore/css/view-source.css \
    960960        Source/WebCore/css/WebKitFontFamilyNames.in \
    961         Source/WebCore/dom/EventFactory.in \
     961        Source/WebCore/dom/EventNames.in \
    962962        Source/WebCore/dom/EventTargetFactory.in \
    963963        Source/WebCore/dom/make_dom_exceptions.pl \

  • trunk/Source/WebCore/WebCore.gyp/WebCore.gyp

    r109036 r109068  
    729729          'inputs': [
    730730            '../dom/make_event_factory.pl',
    731             '../dom/EventFactory.in',
     731            '../dom/EventNames.in',
    732732          ],
    733733          'outputs': [

  • trunk/Source/WebCore/WebCore.gyp/scripts/action_makenames.py

    r98793 r109068  
    131131            assert attrInput == None
    132132            attrInput = inputAbsPosix
    133         elif inputBasename.endswith('EventFactory.in') \
    134             or inputBasename.endswith('EventTargetFactory.in') \
     133        elif inputBasename.endswith('EventTargetFactory.in') \
     134            or inputBasename.endswith('EventNames.in') \
    135135            or inputBasename.endswith('DOMExceptions.in'):
    136136            eventsInput = inputAbsPosix

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r109036 r109068  
    1228812288                BC99812D0DBE807A008CE9EF /* DOMAbstractViewFrame.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMAbstractViewFrame.h; sourceTree = "<group>"; };
    1228912289                BC9A6141146859D9006057FD /* DOMExceptions.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = DOMExceptions.in; sourceTree = "<group>"; };
    12290                 BC9A6142146859D9006057FD /* EventFactory.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = EventFactory.in; sourceTree = "<group>"; };
     12290                BC9A6142146859D9006057FD /* EventNames.in */ = {isa = PBXFileReference; lastKnownFileType = text; path = EventNames.in; sourceTree = "<group>"; };
    1229112291                BC9A6144146859D9006057FD /* make_dom_exceptions.pl */ = {isa = PBXFileReference; lastKnownFileType = text.script.perl; path = make_dom_exceptions.pl; sourceTree = "<group>"; };
    1229212292                BC9A6145146859D9006057FD /* make_event_factory.pl */ = {isa = PBXFileReference; lastKnownFileType = text.script.perl; path = make_event_factory.pl; sourceTree = "<group>"; };
    … …  
    1925119251                        isa = PBXGroup;
    1925219252                        children = (
    19253                                 A83B538014FBB2EC00720D9D /* preprocess-idls.pl */,
    1925419253                                B5D31DF711CF60E5009F22B4 /* generic */,
    1925519254                                BC1A3793097C6FB10019F3D8 /* js */,
    … …  
    1926019259                                14813BF309EDF88E00F757E1 /* IDLParser.pm */,
    1926119260                                93F8B3080A300FEA00F61AB8 /* IDLStructure.pm */,
     19261                                A83B538014FBB2EC00720D9D /* preprocess-idls.pl */,
    1926219262                                C0F2A43F13869A280066C534 /* preprocessor.pm */,
    1926319263                                8C6EA61711EF7E0400FD8EE3 /* RuntimeEnabledFeatures.cpp */,
    … …  
    2068420684                                BC60D6E80D28D83400B9918F /* DOMCoreException.h */,
    2068520685                                BC60D6EB0D28D99900B9918F /* DOMCoreException.idl */,
     20686                                BC9A6142146859D9006057FD /* EventNames.in */,
    2068620687                                BC9A6141146859D9006057FD /* DOMExceptions.in */,
    2068720688                                A8185F3609765765005826D9 /* DOMImplementation.cpp */,
    … …  
    2072620727                                BC60D90A0D2A17CE00B9918F /* EventException.idl */,
    2072720728                                97665011144FAA4200F6BB51 /* EventFactory.h */,
    20728                                 BC9A6142146859D9006057FD /* EventFactory.in */,
    2072920729                                935FBC4409BA00B900E230B1 /* EventListener.h */,
    2073020730                                85AFA7410AAF298400E84305 /* EventListener.idl */,
    … …  
    2352423524                                BC4368E80C226E32005EFB5F /* Rect.h in Headers */,
    2352523525                                BCAB418213E356E800D8AAF3 /* Region.h in Headers */,
     23526                                8ABAFBA014F5107500A4984B /* RegionNodeList.h in Headers */,
    2352623527                                85031B4C0A44EFC700F992E0 /* RegisteredEventListener.h in Headers */,
    2352723528                                B2C3DA2D0D006C1D00EF6F26 /* RegularExpression.h in Headers */,
    … …  
    2438024381                                977E2E0F12F0FC9C00C13379 /* XSSAuditor.h in Headers */,
    2438124382                                FD537353137B651800008DCE /* ZeroPole.h in Headers */,
    24382                                 8ABAFBA014F5107500A4984B /* RegionNodeList.h in Headers */,
    2438324383                        );
    2438424384                        runOnlyForDeploymentPostprocessing = 0;
    … …  
    2663926639                                FD31603D12B0267600C1A359 /* RealtimeAnalyserNode.cpp in Sources */,
    2664026640                                BCAB418113E356E800D8AAF3 /* Region.cpp in Sources */,
     26641                                8ABAFB9F14F5107500A4984B /* RegionNodeList.cpp in Sources */,
    2664126642                                85031B4B0A44EFC700F992E0 /* RegisteredEventListener.cpp in Sources */,
    2664226643                                B2C3DA2C0D006C1D00EF6F26 /* RegularExpression.cpp in Sources */,
    … …  
    2733427335                                977E2E0E12F0FC9C00C13379 /* XSSAuditor.cpp in Sources */,
    2733527336                                FD537352137B651800008DCE /* ZeroPole.cpp in Sources */,
    27336                                 8ABAFB9F14F5107500A4984B /* RegionNodeList.cpp in Sources */,
    2733727337                        );
    2733827338                        runOnlyForDeploymentPostprocessing = 0;
Note: See TracChangeset for help on using the changeset viewer.