Changeset 109183 in webkit

Timestamp:

Feb 28, 2012 6:36:08 PM (12 years ago)

Author:

andersca@apple.com

Message:

With tiled drawing enabled, pressing Down arrow after scrolling via mouse gesture causes page to jump back up to top
​https://bugs.webkit.org/show_bug.cgi?id=79249
<rdar://problem/10866273>

Reviewed by Sam Weinig.

ScrollableArea::notifyScrollPositionChanged must make sure that the scroll animator position is kept up to date.

• platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::setCurrentPosition):
(WebCore):

• platform/ScrollAnimator.h:

(ScrollAnimator):

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::notifyScrollPositionChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ScrollAnimator.cpp (modified) (1 diff)
• platform/ScrollAnimator.h (modified) (1 diff)
• platform/ScrollableArea.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-28  Anders Carlsson  <andersca@apple.com>
+
+        With tiled drawing enabled, pressing Down arrow after scrolling via mouse gesture causes page to jump back up to top
+        https://bugs.webkit.org/show_bug.cgi?id=79249
+        <rdar://problem/10866273>
+
+        Reviewed by Sam Weinig.
+
+        ScrollableArea::notifyScrollPositionChanged must make sure that the scroll animator position is kept up to date.
+
+        * platform/ScrollAnimator.cpp:
+        (WebCore::ScrollAnimator::setCurrentPosition):
+        (WebCore):
+        * platform/ScrollAnimator.h:
+        (ScrollAnimator):
+        * platform/ScrollableArea.cpp:
+        (WebCore::ScrollableArea::notifyScrollPositionChanged):
+
 2012-02-28  Daniel Cheng  <dcheng@chromium.org>
 

trunk/Source/WebCore/platform/ScrollAnimator.cpp

@@ -123 +123 @@
 }
 
+void ScrollAnimator::setCurrentPosition(const FloatPoint& position)
+{
+    m_currentPosX = position.x();
+    m_currentPosY = position.y();
+}
+
 FloatPoint ScrollAnimator::currentPosition() const
 {

trunk/Source/WebCore/platform/ScrollAnimator.h

@@ -66 +66 @@
     virtual bool handleWheelEvent(const PlatformWheelEvent&);
 
+    void setCurrentPosition(const FloatPoint&);
     FloatPoint currentPosition() const;
 

trunk/Source/WebCore/platform/ScrollableArea.cpp

@@ -151 +151 @@
     }
 
+    scrollAnimator()->setCurrentPosition(position);
     scrollAnimator()->notifyContentAreaScrolled();
 }