Changeset 109232 in webkit

Timestamp:

Feb 29, 2012 10:56:11 AM (12 years ago)

Author:

kbalazs@webkit.org

Message:

[Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
​https://bugs.webkit.org/show_bug.cgi?id=76546

Reviewed by Simon Hausmann.

Revert the workaround introduced in r107868 and reintroduce
the qml binding so we can test the code path that we are more
interested in. The reason that it did not work before is that
we don't have an active platform window which we now workaround
by propagating the resize through QWindowSystemInterface.

• WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::WrapperWindow::handleStatusChanged):
(WTR::PlatformWebView::resizeTo):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/qt/PlatformWebViewQt.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
+
+        [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
+        https://bugs.webkit.org/show_bug.cgi?id=76546
+
+        Reviewed by Simon Hausmann.
+
+        Revert the workaround introduced in r107868 and reintroduce
+        the qml binding so we can test the code path that we are more
+        interested in. The reason that it did not work before is that
+        we don't have an active platform window which we now workaround
+        by propagating the resize through QWindowSystemInterface.
+
+        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+        (WTR::WrapperWindow::handleStatusChanged):
+        (WTR::PlatformWebView::resizeTo):
+
 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
 

trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp

@@ -56 +56 @@
 
         setGeometry(0, 0, 800, 600);
-        m_view->setX(0);
-        m_view->setY(0);
-        m_view->setWidth(800);
-        m_view->setHeight(600);
 
         setResizeMode(QQuickView::SizeRootObjectToView);
-
         m_view->setParentItem(rootObject());
+        QDeclarativeProperty::write(m_view, "anchors.fill", qVariantFromValue(rootObject()));
 
         QWindowSystemInterface::handleWindowActivated(this);
@@ -92 +88 @@
 void PlatformWebView::resizeTo(unsigned width, unsigned height)
 {
+    // If we do not have a platform window we will never get the necessary
+    // resize event, so simulate it in that case to make sure the quickview is
+    // resized to what the layout test expects.
+    if (!m_window->handle()) {
+        QRect newGeometry(m_window->x(), m_window->y(), width, height);
+        QWindowSystemInterface::handleSynchronousGeometryChange(m_window, newGeometry);
+    }
+
     m_window->resize(width, height);
-    m_view->setWidth(width);
-    m_view->setHeight(height);
 }