Changeset 109235 in webkit

Timestamp:

Feb 29, 2012 11:48:43 AM (12 years ago)

Author:

dpranke@chromium.org

Message:

perftestsrunner can call printer.write() after printer.cleanup()
​https://bugs.webkit.org/show_bug.cgi?id=79872

Reviewed by Ryosuke Niwa.

This patch fixes a unittest that was incorrectly calling
PerfTestsRunner.run() twice (which led to a weird state in the
printer object).

• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.test_run_with_upload_json):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-29  Dirk Pranke  <dpranke@chromium.org>
+
+        perftestsrunner can call printer.write() after printer.cleanup()
+        https://bugs.webkit.org/show_bug.cgi?id=79872
+
+        Reviewed by Ryosuke Niwa.
+
+        This patch fixes a unittest that was incorrectly calling
+        PerfTestsRunner.run() twice (which led to a weird state in the
+        printer object).
+
+        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+        (MainTest.test_run_with_upload_json):
+
 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
 

trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py

@@ -281 +281 @@
         self.assertEqual(generated_json['build-number'], 123)
         upload_json_returns_true = False
+
+        runner = self.create_runner(args=['--output-json-path=/mock-checkout/output.json',
+            '--test-results-server', 'some.host', '--platform', 'platform1', '--builder-name', 'builder1', '--build-number', '123'])
+        runner._upload_json = mock_upload_json
         self.assertEqual(runner.run(), -3)