Changeset 109238 in webkit


Ignore:
Timestamp:
Feb 29, 2012 11:53:49 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
https://bugs.webkit.org/show_bug.cgi?id=79519

Patch by Max Feil <mfeil@rim.com> on 2012-02-29
Reviewed by Antonio Gomes.

Source/WebCore:

A layout test already exists for OGG. We do not support OGG
video at this time, only audio.

Test: media/media-can-play-flac-audio.html

  • platform/blackberry/MIMETypeRegistryBlackBerry.cpp:

(WebCore):

Source/WebKit/blackberry:

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::mimeTypeAssociationMap):

LayoutTests:

A layout test already exists for OGG. We do not support OGG
video at this time, only audio.

  • media/media-can-play-flac-audio-expected.txt: Added.
  • media/media-can-play-flac-audio.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
Location:
trunk
Files:
2 added
12 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r109236 r109238  
     12012-02-29  Max Feil  <mfeil@rim.com>
     2
     3        [BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
     4        https://bugs.webkit.org/show_bug.cgi?id=79519
     5
     6        Reviewed by Antonio Gomes.
     7
     8        A layout test already exists for OGG. We do not support OGG
     9        video at this time, only audio.
     10
     11        * media/media-can-play-flac-audio-expected.txt: Added.
     12        * media/media-can-play-flac-audio.html: Added.
     13        * platform/chromium/test_expectations.txt:
     14        * platform/efl/Skipped:
     15        * platform/gtk/Skipped:
     16        * platform/mac/Skipped:
     17        * platform/qt/Skipped:
     18        * platform/win/Skipped:
     19        * platform/wincairo/Skipped:
     20
    1212012-02-29  Greg Billock  <gbillock@google.com>
    222
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r109233 r109238  
    486486WONTFIX SKIP : media/media-can-play-mpeg-audio.html = TEXT
    487487WONTFIX SKIP : media/media-can-play-mpeg4-video.html = TEXT
     488WONTFIX SKIP : media/media-can-play-flac-audio.html = TEXT
    488489WONTFIX SKIP : media/video-can-play-type.html = TIMEOUT FAIL
    489490WONTFIX SKIP : media/video-document-types.html = TIMEOUT FAIL
  • trunk/LayoutTests/platform/efl/Skipped

    r109179 r109238  
    28742874media/video-colorspace-yuv422.html
    28752875perf/nested-combined-selectors.html
     2876
     2877# This test requires flac codec
     2878media/media-can-play-flac-audio.html
     2879
  • trunk/LayoutTests/platform/gtk/Skipped

    r109196 r109238  
    15981598fast/mediastream/peerconnection-Attributes.html
    15991599fast/mediastream/peerconnection-argument-types.html
     1600
     1601# This test requires flac codec
     1602media/media-can-play-flac-audio.html
  • trunk/LayoutTests/platform/mac/Skipped

    r109196 r109238  
    8989media/media-can-play-ogg.html
    9090
     91# This test requires flac codec
     92media/media-can-play-flac-audio.html
     93
    9194# These tests require touch support
    9295fast/events/touch
  • trunk/LayoutTests/platform/qt/Skipped

    r109202 r109238  
    959959media/video-zoom-controls.html
    960960media/video-zoom.html
     961
     962# This test requires flac codec
     963media/media-can-play-flac-audio.html
    961964
    962965# Video size reported as 0,0 due to how size-hints are reported by QtMultimedia
  • trunk/LayoutTests/platform/win/Skipped

    r109196 r109238  
    908908# This test requires ogg codecs
    909909media/media-can-play-ogg.html
     910
     911# This test requires flac codec
     912media/media-can-play-flac-audio.html
    910913
    911914# These tests require touch support
  • trunk/LayoutTests/platform/wincairo/Skipped

    r109196 r109238  
    14311431media/media-can-play-ogg.html
    14321432
     1433# This test requires flac codec
     1434media/media-can-play-flac-audio.html
     1435
    14331436# These tests require touch support
    14341437fast/events/touch
  • trunk/Source/WebCore/ChangeLog

    r109237 r109238  
     12012-02-29  Max Feil  <mfeil@rim.com>
     2
     3        [BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
     4        https://bugs.webkit.org/show_bug.cgi?id=79519
     5
     6        Reviewed by Antonio Gomes.
     7
     8        A layout test already exists for OGG. We do not support OGG
     9        video at this time, only audio.
     10
     11        Test: media/media-can-play-flac-audio.html
     12
     13        * platform/blackberry/MIMETypeRegistryBlackBerry.cpp:
     14        (WebCore):
     15
    1162012-02-28  Beth Dakin  <bdakin@apple.com>
    217
  • trunk/Source/WebCore/platform/blackberry/MIMETypeRegistryBlackBerry.cpp

    r102426 r109238  
    9898    { "m3url", "audio/mpegurl" },
    9999    { "m3u", "audio/mpegurl" },
     100    { "flac", "audio/x-flac" },
     101    { "ogg", "audio/ogg" },
     102    { "oga", "audio/ogg" },
    100103    // FIXME: wince also maps ttf and otf to text/plain. Should we do that too?
    101104    { 0, 0 }
  • trunk/Source/WebKit/blackberry/Api/WebSettings.cpp

    r107764 r109238  
    132132    mimeTypeMap->add("audio/x-amr", "audio/amr");
    133133    mimeTypeMap->add("audio/mpegurl", "audio/x-mpegurl");
     134    mimeTypeMap->add("audio/flac", "audio/x-flac");
    134135    mimeTypeMap->add("video/3gp", "video/3gpp");
    135136    mimeTypeMap->add("video/avi", "video/x-msvideo");
  • trunk/Source/WebKit/blackberry/ChangeLog

    r109150 r109238  
     12012-02-29  Max Feil  <mfeil@rim.com>
     2
     3        [BlackBerry] Add support for FLAC audio and OGG/Vorbis audio
     4        https://bugs.webkit.org/show_bug.cgi?id=79519
     5
     6        Reviewed by Antonio Gomes.
     7
     8        * Api/WebSettings.cpp:
     9        (BlackBerry::WebKit::mimeTypeAssociationMap):
     10
    1112012-02-28  Konrad Piascik  <kpiascik@rim.com>
    212
Note: See TracChangeset for help on using the changeset viewer.