Changeset 109286 in webkit

Timestamp:

Feb 29, 2012 5:17:33 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

<msubsup> setNeedsLayout() correction
​https://bugs.webkit.org/show_bug.cgi?id=79856

Patch by David Barton <Dave Barton> on 2012-02-29
Reviewed by Julien Chaffraix.

m_scripts->setNeedsLayout(true, false); needs to be added to the fix for bug 79274.

No new tests. It's actually difficult to test the need for this with the current code,
because there are a lot of extra setNeedsLayout() calls right now. I caught this after
removing some of those calls that should be redundant, for a future patch. Actually
removing those calls now changes other behavior, due to other bugs, so I'll save all
that for future patches. We should land this fix now though I think, as it could
possibly matter in some cases.

• rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::layout):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/mathml/RenderMathMLSubSup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-29  David Barton  <dbarton@mathscribe.com>
+
+        <msubsup> setNeedsLayout() correction
+        https://bugs.webkit.org/show_bug.cgi?id=79856
+
+        Reviewed by Julien Chaffraix.
+
+        m_scripts->setNeedsLayout(true, false); needs to be added to the fix for bug 79274.
+
+        No new tests. It's actually difficult to test the need for this with the current code,
+        because there are a lot of extra setNeedsLayout() calls right now. I caught this after
+        removing some of those calls that should be redundant, for a future patch. Actually
+        removing those calls now changes other behavior, due to other bugs, so I'll save all
+        that for future patches. We should land this fix now though I think, as it could
+        possibly matter in some cases.
+
+        * rendering/mathml/RenderMathMLSubSup.cpp:
+        (WebCore::RenderMathMLSubSup::layout):
+
 2012-02-29  Andreas Kling  <awesomekling@apple.com>
 

trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp

@@ -184 +184 @@
     superscriptWrapper->style()->setPaddingBottom(Length(superPaddingBottom, Fixed));
     superscriptWrapper->setNeedsLayout(true, false);
+    m_scripts->setNeedsLayout(true, false);
     
     RenderBlock::layout();