Changeset 109306 in webkit


Ignore:
Timestamp:
Feb 29, 2012 9:34:33 PM (12 years ago)
Author:
arv@chromium.org
Message:

Rename DOMSelection to Selection
​https://bugs.webkit.org/show_bug.cgi?id=79688

Reviewed by Adam Barth.

Source/WebCore:

No new tests. Existing tests have been updated to cover this.

  • page/DOMSelection.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt:
  • platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/Window/window-properties-expected.txt:
Location:
trunk
Files:
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r109305 r109306  
     12012-02-29  Erik Arvidsson  <arv@chromium.org>
     2
     3        Rename DOMSelection to Selection
     4        https://bugs.webkit.org/show_bug.cgi?id=79688
     5
     6        Reviewed by Adam Barth.
     7
     8        * fast/dom/Window/window-properties-expected.txt:
     9        * fast/dom/dom-constructors-expected.txt:
     10        * fast/dom/dom-constructors.html:
     11        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
     12        * platform/mac/fast/dom/Window/window-properties-expected.txt:
     13        * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
     14        * platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
     15        * platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
     16        * platform/qt/fast/dom/Window/window-properties-expected.txt:
     17        * platform/win/fast/dom/Window/window-properties-expected.txt:
     18
    1192012-02-29  Joshua Bell  <jsbell@chromium.org>
    220

  • trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

    r108729 r109306  
    24952495window.webkitConvertPointFromPageToNode [function]
    24962496window.window [printed above as window]
    2497 window.getSelection() [object DOMSelection]
     2497window.getSelection() [object Selection]
    24982498window.getSelection().addRange [function]
    24992499window.getSelection().anchorNode [null]

  • trunk/LayoutTests/fast/dom/dom-constructors-expected.txt

    r108729 r109306  
    116116PASS TryAllocate('CanvasPattern') is 'exception'
    117117FAIL TryAllocate('Console') should be exception. Was no constructor.
    118 FAIL TryAllocate('DOMSelection') should be exception. Was no constructor.
     118PASS TryAllocate('Selection') is 'exception'
    119119PASS TryAllocate('Window') is 'exception'
    120120FAIL TryAllocate('History') should be exception. Was no constructor.

  • trunk/LayoutTests/fast/dom/dom-constructors.html

    r108729 r109306  
    4848    'PluginArray', 'Range', 'Rect', 'StyleSheet', 'StyleSheetList',
    4949    'TextEvent', 'UIEvent', 'WheelEvent', 'XPathResult', 'BarInfo',
    50     'CanvasGradient', 'CanvasPattern', 'Console', 'DOMSelection',
     50    'CanvasGradient', 'CanvasPattern', 'Console', 'Selection',
    5151    'Window', 'History', 'HTMLOptionsCollection', 'Location',
    5252    'Navigator', 'NodeIterator', 'RGBColor', 'Screen', 'TreeWalker',

  • trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt

    r109083 r109306  
    21022102window.SVGZoomEvent [object SVGZoomEventConstructor]
    21032103window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
     2104window.Selection [object SelectionConstructor]
     2105window.Selection.prototype [object SelectionPrototype]
     2106window.Selection.prototype.addRange [function]
     2107window.Selection.prototype.collapse [function]
     2108window.Selection.prototype.collapseToEnd [function]
     2109window.Selection.prototype.collapseToStart [function]
     2110window.Selection.prototype.containsNode [function]
     2111window.Selection.prototype.deleteFromDocument [function]
     2112window.Selection.prototype.empty [function]
     2113window.Selection.prototype.extend [function]
     2114window.Selection.prototype.getRangeAt [function]
     2115window.Selection.prototype.modify [function]
     2116window.Selection.prototype.removeAllRanges [function]
     2117window.Selection.prototype.selectAllChildren [function]
     2118window.Selection.prototype.setBaseAndExtent [function]
     2119window.Selection.prototype.setPosition [function]
     2120window.Selection.prototype.toString [function]
    21042121window.SharedWorker [object SharedWorkerConstructor]
    21052122window.SharedWorker.length [number]
    … …  
    26862703window.webkitRequestAnimationFrame [function]
    26872704window.window [printed above as window]
    2688 window.getSelection() [object DOMSelection]
    2689 window.getSelection().addRange [function]
    2690 window.getSelection().anchorNode [null]
    2691 window.getSelection().anchorOffset [number]
    2692 window.getSelection().baseNode [null]
    2693 window.getSelection().baseOffset [number]
    2694 window.getSelection().collapse [function]
    2695 window.getSelection().collapseToEnd [function]
    2696 window.getSelection().collapseToStart [function]
    2697 window.getSelection().containsNode [function]
    2698 window.getSelection().deleteFromDocument [function]
    2699 window.getSelection().empty [function]
    2700 window.getSelection().extend [function]
    2701 window.getSelection().extentNode [null]
    2702 window.getSelection().extentOffset [number]
    2703 window.getSelection().focusNode [null]
    2704 window.getSelection().focusOffset [number]
    2705 window.getSelection().getRangeAt [function]
    2706 window.getSelection().isCollapsed [boolean]
    2707 window.getSelection().modify [function]
    2708 window.getSelection().rangeCount [number]
    2709 window.getSelection().removeAllRanges [function]
    2710 window.getSelection().selectAllChildren [function]
    2711 window.getSelection().setBaseAndExtent [function]
    2712 window.getSelection().setPosition [function]
    2713 window.getSelection().toString [function]
    2714 window.getSelection().type [string]
     2705window.getSelection() [printed above as window.Selection.prototype]
    27152706

  • trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt

    r108729 r109306  
    21112111window.SVGZoomEvent [object SVGZoomEventConstructor]
    21122112window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
     2113window.Selection [object SelectionConstructor]
     2114window.Selection.prototype [object SelectionPrototype]
     2115window.Selection.prototype.addRange [function]
     2116window.Selection.prototype.collapse [function]
     2117window.Selection.prototype.collapseToEnd [function]
     2118window.Selection.prototype.collapseToStart [function]
     2119window.Selection.prototype.containsNode [function]
     2120window.Selection.prototype.deleteFromDocument [function]
     2121window.Selection.prototype.empty [function]
     2122window.Selection.prototype.extend [function]
     2123window.Selection.prototype.getRangeAt [function]
     2124window.Selection.prototype.modify [function]
     2125window.Selection.prototype.removeAllRanges [function]
     2126window.Selection.prototype.selectAllChildren [function]
     2127window.Selection.prototype.setBaseAndExtent [function]
     2128window.Selection.prototype.setPosition [function]
     2129window.Selection.prototype.toString [function]
    21132130window.SharedWorker [object SharedWorkerConstructor]
    21142131window.SharedWorker.length [number]
    … …  
    27062723window.webkitRequestAnimationFrame [function]
    27072724window.window [printed above as window]
    2708 window.getSelection() [object DOMSelection]
    2709 window.getSelection().addRange [function]
    2710 window.getSelection().anchorNode [null]
    2711 window.getSelection().anchorOffset [number]
    2712 window.getSelection().baseNode [null]
    2713 window.getSelection().baseOffset [number]
    2714 window.getSelection().collapse [function]
    2715 window.getSelection().collapseToEnd [function]
    2716 window.getSelection().collapseToStart [function]
    2717 window.getSelection().containsNode [function]
    2718 window.getSelection().deleteFromDocument [function]
    2719 window.getSelection().empty [function]
    2720 window.getSelection().extend [function]
    2721 window.getSelection().extentNode [null]
    2722 window.getSelection().extentOffset [number]
    2723 window.getSelection().focusNode [null]
    2724 window.getSelection().focusOffset [number]
    2725 window.getSelection().getRangeAt [function]
    2726 window.getSelection().isCollapsed [boolean]
    2727 window.getSelection().modify [function]
    2728 window.getSelection().rangeCount [number]
    2729 window.getSelection().removeAllRanges [function]
    2730 window.getSelection().selectAllChildren [function]
    2731 window.getSelection().setBaseAndExtent [function]
    2732 window.getSelection().setPosition [function]
    2733 window.getSelection().toString [function]
    2734 window.getSelection().type [string]
     2725window.getSelection() [printed above as window.Selection.prototype]
    27352726

  • trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt

    r108729 r109306  
    312312PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGViewElement') is 'object'
    313313PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGZoomEvent') is 'object'
     314PASS typeof Object.getOwnPropertyDescriptor(window, 'Selection') is 'object'
    314315PASS typeof Object.getOwnPropertyDescriptor(window, 'SharedWorker') is 'object'
    315316PASS typeof Object.getOwnPropertyDescriptor(window, 'Storage') is 'object'

  • trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt

    r108729 r109306  
    270270Never found HTMLIFrameElement
    271271Never found HTMLImageElement
    272 Never found HTMLIsIndexElement
    273272Never found HTMLKeygenElement
    274273Never found HTMLLIElement
    … …  
    449448Never found SVGVKernElement
    450449Never found SVGViewElement
     450Never found Selection
    451451Never found SharedWorker
    452452Never found StyleSheet

  • trunk/LayoutTests/platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt

    r108729 r109306  
    20452045window.SVGZoomEvent [object SVGZoomEventConstructor]
    20462046window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
     2047window.Selection [object SelectionConstructor]
     2048window.Selection.prototype [object SelectionPrototype]
     2049window.Selection.prototype.addRange [function]
     2050window.Selection.prototype.collapse [function]
     2051window.Selection.prototype.collapseToEnd [function]
     2052window.Selection.prototype.collapseToStart [function]
     2053window.Selection.prototype.containsNode [function]
     2054window.Selection.prototype.deleteFromDocument [function]
     2055window.Selection.prototype.empty [function]
     2056window.Selection.prototype.extend [function]
     2057window.Selection.prototype.getRangeAt [function]
     2058window.Selection.prototype.modify [function]
     2059window.Selection.prototype.removeAllRanges [function]
     2060window.Selection.prototype.selectAllChildren [function]
     2061window.Selection.prototype.setBaseAndExtent [function]
     2062window.Selection.prototype.setPosition [function]
     2063window.Selection.prototype.toString [function]
    20472064window.SharedWorker [object SharedWorkerConstructor]
    20482065window.SharedWorker.length [number]
    … …  
    25812598window.webkitRequestAnimationFrame [function]
    25822599window.window [printed above as window]
    2583 window.getSelection() [object DOMSelection]
    2584 window.getSelection().addRange [function]
    2585 window.getSelection().anchorNode [null]
    2586 window.getSelection().anchorOffset [number]
    2587 window.getSelection().baseNode [null]
    2588 window.getSelection().baseOffset [number]
    2589 window.getSelection().collapse [function]
    2590 window.getSelection().collapseToEnd [function]
    2591 window.getSelection().collapseToStart [function]
    2592 window.getSelection().containsNode [function]
    2593 window.getSelection().deleteFromDocument [function]
    2594 window.getSelection().empty [function]
    2595 window.getSelection().extend [function]
    2596 window.getSelection().extentNode [null]
    2597 window.getSelection().extentOffset [number]
    2598 window.getSelection().focusNode [null]
    2599 window.getSelection().focusOffset [number]
    2600 window.getSelection().getRangeAt [function]
    2601 window.getSelection().isCollapsed [boolean]
    2602 window.getSelection().modify [function]
    2603 window.getSelection().rangeCount [number]
    2604 window.getSelection().removeAllRanges [function]
    2605 window.getSelection().selectAllChildren [function]
    2606 window.getSelection().setBaseAndExtent [function]
    2607 window.getSelection().setPosition [function]
    2608 window.getSelection().toString [function]
    2609 window.getSelection().type [string]
     2600window.getSelection() [printed above as window.Selection.prototype]
    26102601

  • trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt

    r109079 r109306  
    20612061window.SVGZoomEvent [object SVGZoomEventConstructor]
    20622062window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
     2063window.Selection [object SelectionConstructor]
     2064window.Selection.prototype [object SelectionPrototype]
     2065window.Selection.prototype.addRange [function]
     2066window.Selection.prototype.collapse [function]
     2067window.Selection.prototype.collapseToEnd [function]
     2068window.Selection.prototype.collapseToStart [function]
     2069window.Selection.prototype.containsNode [function]
     2070window.Selection.prototype.deleteFromDocument [function]
     2071window.Selection.prototype.empty [function]
     2072window.Selection.prototype.extend [function]
     2073window.Selection.prototype.getRangeAt [function]
     2074window.Selection.prototype.modify [function]
     2075window.Selection.prototype.removeAllRanges [function]
     2076window.Selection.prototype.selectAllChildren [function]
     2077window.Selection.prototype.setBaseAndExtent [function]
     2078window.Selection.prototype.setPosition [function]
     2079window.Selection.prototype.toString [function]
    20632080window.SharedWorker [object SharedWorkerConstructor]
    20642081window.SharedWorker.length [number]
    … …  
    26092626window.webkitRequestAnimationFrame [function]
    26102627window.window [printed above as window]
    2611 window.getSelection() [object DOMSelection]
    2612 window.getSelection().addRange [function]
    2613 window.getSelection().anchorNode [null]
    2614 window.getSelection().anchorOffset [number]
    2615 window.getSelection().baseNode [null]
    2616 window.getSelection().baseOffset [number]
    2617 window.getSelection().collapse [function]
    2618 window.getSelection().collapseToEnd [function]
    2619 window.getSelection().collapseToStart [function]
    2620 window.getSelection().containsNode [function]
    2621 window.getSelection().deleteFromDocument [function]
    2622 window.getSelection().empty [function]
    2623 window.getSelection().extend [function]
    2624 window.getSelection().extentNode [null]
    2625 window.getSelection().extentOffset [number]
    2626 window.getSelection().focusNode [null]
    2627 window.getSelection().focusOffset [number]
    2628 window.getSelection().getRangeAt [function]
    2629 window.getSelection().isCollapsed [boolean]
    2630 window.getSelection().modify [function]
    2631 window.getSelection().rangeCount [number]
    2632 window.getSelection().removeAllRanges [function]
    2633 window.getSelection().selectAllChildren [function]
    2634 window.getSelection().setBaseAndExtent [function]
    2635 window.getSelection().setPosition [function]
    2636 window.getSelection().toString [function]
    2637 window.getSelection().type [string]
     2628window.getSelection() [printed above as window.Selection.prototype]
    26382629

  • trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt

    r108729 r109306  
    19921992window.SVGZoomEvent [object SVGZoomEventConstructor]
    19931993window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
     1994window.Selection [object SelectionConstructor]
     1995window.Selection.prototype [object SelectionPrototype]
     1996window.Selection.prototype.addRange [function]
     1997window.Selection.prototype.collapse [function]
     1998window.Selection.prototype.collapseToEnd [function]
     1999window.Selection.prototype.collapseToStart [function]
     2000window.Selection.prototype.containsNode [function]
     2001window.Selection.prototype.deleteFromDocument [function]
     2002window.Selection.prototype.empty [function]
     2003window.Selection.prototype.extend [function]
     2004window.Selection.prototype.getRangeAt [function]
     2005window.Selection.prototype.modify [function]
     2006window.Selection.prototype.removeAllRanges [function]
     2007window.Selection.prototype.selectAllChildren [function]
     2008window.Selection.prototype.setBaseAndExtent [function]
     2009window.Selection.prototype.setPosition [function]
     2010window.Selection.prototype.toString [function]
    19942011window.SharedWorker [object SharedWorkerConstructor]
    19952012window.SharedWorker.length [number]
    … …  
    25082525window.webkitConvertPointFromPageToNode [function]
    25092526window.window [printed above as window]
    2510 window.getSelection() [object DOMSelection]
    2511 window.getSelection().addRange [function]
    2512 window.getSelection().anchorNode [null]
    2513 window.getSelection().anchorOffset [number]
    2514 window.getSelection().baseNode [null]
    2515 window.getSelection().baseOffset [number]
    2516 window.getSelection().collapse [function]
    2517 window.getSelection().collapseToEnd [function]
    2518 window.getSelection().collapseToStart [function]
    2519 window.getSelection().containsNode [function]
    2520 window.getSelection().deleteFromDocument [function]
    2521 window.getSelection().empty [function]
    2522 window.getSelection().extend [function]
    2523 window.getSelection().extentNode [null]
    2524 window.getSelection().extentOffset [number]
    2525 window.getSelection().focusNode [null]
    2526 window.getSelection().focusOffset [number]
    2527 window.getSelection().getRangeAt [function]
    2528 window.getSelection().isCollapsed [boolean]
    2529 window.getSelection().modify [function]
    2530 window.getSelection().rangeCount [number]
    2531 window.getSelection().removeAllRanges [function]
    2532 window.getSelection().selectAllChildren [function]
    2533 window.getSelection().setBaseAndExtent [function]
    2534 window.getSelection().setPosition [function]
    2535 window.getSelection().toString [function]
    2536 window.getSelection().type [string]
     2527window.getSelection() [printed above as window.Selection.prototype]
    25372528

  • trunk/Source/WebCore/ChangeLog

    r109305 r109306  
     12012-02-29  Erik Arvidsson  <arv@chromium.org>
     2
     3        Rename DOMSelection to Selection
     4        https://bugs.webkit.org/show_bug.cgi?id=79688
     5
     6        Reviewed by Adam Barth.
     7
     8        No new tests. Existing tests have been updated to cover this.
     9
     10        * page/DOMSelection.idl:
     11        * page/DOMWindow.idl:
     12
    1132012-02-29  Joshua Bell  <jsbell@chromium.org>
    214

  • trunk/Source/WebCore/page/DOMSelection.idl

    r107304 r109306  
    3434    interface [
    3535        JSGenerateIsReachable=ImplFrame,
    36         OmitConstructor
     36        InterfaceName=Selection
    3737    ] DOMSelection {
    3838        readonly attribute Node anchorNode;

  • trunk/Source/WebCore/page/DOMWindow.idl

    r108787 r109306  
    394394        attribute [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] ShadowRootConstructor WebKitShadowRoot;
    395395
     396        attribute DOMSelectionConstructor Selection;
    396397        attribute DOMWindowConstructor Window;
    397398
Note: See TracChangeset for help on using the changeset viewer.