Changeset 109323 in webkit

Timestamp:

Mar 1, 2012 12:22:20 AM (12 years ago)

Author:

podivilov@chromium.org

Message:

Web Inspector: add UISourceCode.isEditable property.
​https://bugs.webkit.org/show_bug.cgi?id=79909

Reviewed by Vsevolod Vlasov.

• inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):

• inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode.prototype._createUISourceCode):

• inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DebuggerPresentationModel.js (modified) (1 diff)
• inspector/front-end/RawSourceCode.js (modified) (1 diff)
• inspector/front-end/UISourceCode.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-29  Pavel Podivilov  <podivilov@chromium.org>
+
+        Web Inspector: add UISourceCode.isEditable property.
+        https://bugs.webkit.org/show_bug.cgi?id=79909
+
+        Reviewed by Vsevolod Vlasov.
+
+        * inspector/front-end/DebuggerPresentationModel.js:
+        (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
+        * inspector/front-end/RawSourceCode.js:
+        (WebInspector.RawSourceCode.prototype._createUISourceCode):
+        * inspector/front-end/UISourceCode.js:
+        (WebInspector.UISourceCode):
+
 2012-02-29  Shinya Kawanaka  <shinyak@chromium.org> 
 

trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

@@ -265 +265 @@
     canEditScriptSource: function(uiSourceCode)
     {
-        if (!WebInspector.debuggerModel.canSetScriptSource() || this._formatSource)
-            return false;
-        var rawSourceCode = uiSourceCode.rawSourceCode;
-        var script = this._scriptForRawSourceCode(rawSourceCode);
-        return script && !script.lineOffset && !script.columnOffset;
+        return WebInspector.debuggerModel.canSetScriptSource() && uiSourceCode.isEditable;
     },
 

trunk/Source/WebCore/inspector/front-end/RawSourceCode.js

@@ -260 +260 @@
         var uiSourceCode = new WebInspector.UISourceCode(id, url, this, contentProvider);
         uiSourceCode.isContentScript = this.isContentScript;
+        uiSourceCode.isEditable = this._scripts.length === 1 && !this._scripts[0].lineOffset && !this._scripts[0].columnOffset
+                                  && !this._formatted && !this._compilerSourceMapping;
         return uiSourceCode;
     },

trunk/Source/WebCore/inspector/front-end/UISourceCode.js

@@ -44 +44 @@
     this._contentProvider = contentProvider;
     this.isContentScript = false;
+    this.isEditable = false;
     /**
      * @type Array.<function(string,string)>