Changeset 109338 in webkit

Timestamp:

Mar 1, 2012 4:51:43 AM (12 years ago)

Author:

sergio@webkit.org

Message:

[WK2] [GTK] [libsoup] SoupSession should use system CA
​https://bugs.webkit.org/show_bug.cgi?id=79657

Reviewed by Martin Robinson.

SoupSession sould use system CA list to validate SSL
certificates. Do not use strict certificate validation though as
we want clients to decide whether or not accept/decline invalid
certificates (API to be added later).

No new tests required as current behaviour does not change at all
as we continue to accept invalid certificates by default.

• WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/gtk/WebProcessMainGtk.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-03-01  Sergio Villar Senin  <svillar@igalia.com>
+
+        [WK2] [GTK] [libsoup] SoupSession should use system CA
+        https://bugs.webkit.org/show_bug.cgi?id=79657
+
+        Reviewed by Martin Robinson.
+
+        SoupSession sould use system CA list to validate SSL
+        certificates. Do not use strict certificate validation though as
+        we want clients to decide whether or not accept/decline invalid
+        certificates (API to be added later).
+
+        No new tests required as current behaviour does not change at all
+        as we continue to accept invalid certificates by default.
+
+        * WebProcess/gtk/WebProcessMainGtk.cpp:
+        (WebKit::WebProcessMainGtk):
+
 2012-03-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp

@@ -65 +65 @@
     soup_session_add_feature_by_type(session, WEB_TYPE_AUTH_DIALOG);
 
+    // Despite using system CAs to validate certificates we're
+    // accepting invalid certificates by default. New API will be
+    // added later to let client accept/discard invalid certificates.
+    g_object_set(session, SOUP_SESSION_SSL_USE_SYSTEM_CA_FILE, TRUE,
+                 SOUP_SESSION_SSL_STRICT, FALSE, NULL);
+
     RunLoop::run();