Changeset 109350 in webkit

Timestamp:

Mar 1, 2012 9:15:03 AM (12 years ago)

Author:

haraken@chromium.org

Message:

REGRESSION(r109288): WebViewImpl::enableAutoResizeMode loops infinitely
​https://bugs.webkit.org/show_bug.cgi?id=77452

Reviewed by Hajime Morita.

WebViewImpl::enableAutoResizeMode loops infinitely.
This patch fixes the following line:

enableAutoResizeMode(enable, minSize, maxSize);

to

enableAutoResizeMode(minSize, maxSize);

to avoid the infinite loop. I guess this is the change originally intended.

Test: webkit_unit_tests.WebViewTest.AutoResizeMinimumSize

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::enableAutoResizeMode):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebViewImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-03-01  Kentaro Hara  <haraken@chromium.org>
+
+        REGRESSION(r109288): WebViewImpl::enableAutoResizeMode loops infinitely
+        https://bugs.webkit.org/show_bug.cgi?id=77452
+
+        Reviewed by Hajime Morita.
+
+        WebViewImpl::enableAutoResizeMode loops infinitely.
+        This patch fixes the following line:
+
+            enableAutoResizeMode(enable, minSize, maxSize);
+
+        to
+            enableAutoResizeMode(minSize, maxSize);
+
+        to avoid the infinite loop. I guess this is the change originally intended.
+
+        Test: webkit_unit_tests.WebViewTest.AutoResizeMinimumSize
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::enableAutoResizeMode):
+
 2012-02-29  Kinuko Yasuda  <kinuko@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -2283 +2283 @@
 {
     if (enable)
-        enableAutoResizeMode(enable, minSize, maxSize);
+        enableAutoResizeMode(minSize, maxSize);
     else
         disableAutoResizeMode();