Changeset 109402 in webkit
- Timestamp:
- Mar 1, 2012 12:55:53 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 12 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/ChangeLog
r109320 r109402 1 2012-03-01 Kangil Han <kangil.han@samsung.com> 2 3 [DRT] Remove all PlainTextController usages in existing tests by adding internal API 4 https://bugs.webkit.org/show_bug.cgi?id=78570 5 6 Reviewed by Hajime Morita. 7 8 This patch will remove all PlainTextController usages 9 in existing DRT tests by adding internal API to WebCore/testing/Internals 10 11 * Source/autotools/symbols.filter: 12 1 13 2012-02-29 Ryosuke Niwa <rniwa@webkit.org> 2 14 -
trunk/LayoutTests/ChangeLog
r109397 r109402 1 2012-03-01 Kangil Han <kangil.han@samsung.com> 2 3 [DRT] Remove all PlainTextController usages in existing tests by adding internal API 4 https://bugs.webkit.org/show_bug.cgi?id=78570 5 6 Reviewed by Hajime Morita. 7 8 This patch will remove all PlainTextController usages 9 in existing DRT tests by adding internal API to WebCore/testing/Internals 10 11 * editing/text-iterator/basic-iteration-expected.txt: 12 * editing/text-iterator/script-tests/basic-iteration.js: 13 1 14 2012-03-01 Adam Klein <adamk@chromium.org> 2 15 -
trunk/LayoutTests/editing/text-iterator/basic-iteration-expected.txt
r43533 r109402 4 4 5 5 6 PASS range.selectNodeContents(testDocument.body); plainText.plainText(range) is ""7 PASS range.selectNodeContents(testDocument.body); plainText.plainText(range) is "a"8 PASS range.selectNodeContents(testDocument.body); plainText.plainText(range) is "a"9 PASS range.selectNodeContents(testDocument.body); plainText.plainText(range) is "a\nb"10 PASS range.selectNodeContents(testDocument.body); plainText.plainText(range) is "debugging this note"11 FAIL range.selectNodeContents(testDocument.body); plainText.plainText(range) should be Hello6 PASS range.selectNodeContents(testDocument.body); internals.rangeAsText(range) is "" 7 PASS range.selectNodeContents(testDocument.body); internals.rangeAsText(range) is "a" 8 PASS range.selectNodeContents(testDocument.body); internals.rangeAsText(range) is "a" 9 PASS range.selectNodeContents(testDocument.body); internals.rangeAsText(range) is "a\nb" 10 PASS range.selectNodeContents(testDocument.body); internals.rangeAsText(range) is "debugging this note" 11 FAIL range.selectNodeContents(testDocument.body); internals.rangeAsText(range) should be Hello 12 12 . Was Hello 13 13 14 14 . 15 PASS range.selectNodeContents(testDocument.body); plainText.plainText(range) is "hey"16 PASS range.setStartBefore(testDocument.body); range.setEndAfter(testDocument.body); plainText.plainText(range) is "hey"15 PASS range.selectNodeContents(testDocument.body); internals.rangeAsText(range) is "hey" 16 PASS range.setStartBefore(testDocument.body); range.setEndAfter(testDocument.body); internals.rangeAsText(range) is "hey" 17 17 PASS successfullyParsed is true 18 18 -
trunk/LayoutTests/editing/text-iterator/script-tests/basic-iteration.js
r48549 r109402 11 11 12 12 testDocument.body.innerHTML = ''; 13 shouldBe('range.selectNodeContents(testDocument.body); plainText.plainText(range)', '""');13 shouldBe('range.selectNodeContents(testDocument.body); internals.rangeAsText(range)', '""'); 14 14 15 15 testDocument.body.innerHTML = 'a'; 16 shouldBe('range.selectNodeContents(testDocument.body); plainText.plainText(range)', '"a"');16 shouldBe('range.selectNodeContents(testDocument.body); internals.rangeAsText(range)', '"a"'); 17 17 18 18 testDocument.body.innerHTML = '<div>a</div>'; 19 shouldBe('range.selectNodeContents(testDocument.body); plainText.plainText(range)', '"a"');19 shouldBe('range.selectNodeContents(testDocument.body); internals.rangeAsText(range)', '"a"'); 20 20 21 21 testDocument.body.innerHTML = '<div>a</div><div>b</div>'; 22 shouldBe('range.selectNodeContents(testDocument.body); plainText.plainText(range)', '"a\\nb"');22 shouldBe('range.selectNodeContents(testDocument.body); internals.rangeAsText(range)', '"a\\nb"'); 23 23 24 24 testDocument.body.innerHTML = '<div style="line-height: 18px; min-height: 436px; " id="node-content" class="note-content">debugging this note</div>'; 25 shouldBe('range.selectNodeContents(testDocument.body); plainText.plainText(range)', '"debugging this note"');25 shouldBe('range.selectNodeContents(testDocument.body); internals.rangeAsText(range)', '"debugging this note"'); 26 26 27 27 testDocument.body.innerHTML = '<div>Hello<div><span><span><br></div></div>'; 28 shouldBe('range.selectNodeContents(testDocument.body); plainText.plainText(range)', '"Hello\\n"');28 shouldBe('range.selectNodeContents(testDocument.body); internals.rangeAsText(range)', '"Hello\\n"'); 29 29 30 30 testDocument.body.innerHTML = '<div class="note-rule-vertical" style="left:22px"></div>\n\t\t<div class="note-rule-vertical" style="left:26px"></div>\n\n\t\t<div class="note-wrapper">\n\t\t\t<div class="note-header">\n\t\t\t\t<div class="note-body" id="note-body">\n\t\t\t\t\t<div class="note-content" id="note-content" contenteditable="true" style="line-height: 20px; min-height: 580px; ">hey</div>\n\t\t\t\t</div>\n\t\t\t</div>\n\t\t</div>\n\t\n'; 31 shouldBe('range.selectNodeContents(testDocument.body); plainText.plainText(range)', '"hey"');32 shouldBe('range.setStartBefore(testDocument.body); range.setEndAfter(testDocument.body); plainText.plainText(range)', '"hey"');31 shouldBe('range.selectNodeContents(testDocument.body); internals.rangeAsText(range)', '"hey"'); 32 shouldBe('range.setStartBefore(testDocument.body); range.setEndAfter(testDocument.body); internals.rangeAsText(range)', '"hey"'); 33 33 34 34 document.body.removeChild(subframe); -
trunk/Source/WebCore/ChangeLog
r109392 r109402 1 2012-03-01 Kangil Han <kangil.han@samsung.com> 2 3 [DRT] Remove all PlainTextController usages in existing tests by adding internal API 4 https://bugs.webkit.org/show_bug.cgi?id=78570 5 6 Reviewed by Hajime Morita. 7 8 This patch will remove all PlainTextController usages 9 in existing DRT tests by adding internal API to WebCore/testing/Internals 10 11 Changed editing/text-iterator/script-tests/basic-iteration.js to use internals.rangeAsText 12 13 * testing/Internals.cpp: 14 (WebCore::Internals::rangeAsText): 15 (WebCore): 16 * testing/Internals.h: 17 (Internals): 18 * testing/Internals.idl: 19 1 20 2012-03-01 Adam Barth <abarth@webkit.org> 2 21 -
trunk/Source/WebCore/testing/Internals.cpp
r109096 r109402 547 547 } 548 548 549 String Internals::rangeAsText(const Range* range, ExceptionCode& ec) 550 { 551 if (!range) { 552 ec = INVALID_ACCESS_ERR; 553 return String(); 554 } 555 556 return range->text(); 557 } 558 549 559 int Internals::lastSpellCheckRequestSequence(Document* document, ExceptionCode& ec) 550 560 { -
trunk/Source/WebCore/testing/Internals.h
r109096 r109402 107 107 unsigned locationFromRange(Element* scope, const Range*, ExceptionCode&); 108 108 unsigned lengthFromRange(Element* scope, const Range*, ExceptionCode&); 109 String rangeAsText(const Range*, ExceptionCode&); 109 110 110 111 int lastSpellCheckRequestSequence(Document*, ExceptionCode&); -
trunk/Source/WebCore/testing/Internals.idl
r109195 r109402 83 83 unsigned long locationFromRange(in Element scope, in Range range) raises (DOMException); 84 84 unsigned long lengthFromRange(in Element scope, in Range range) raises (DOMException); 85 DOMString rangeAsText(in Range range) raises (DOMException); 85 86 86 87 long lastSpellCheckRequestSequence(in Document document) raises (DOMException); -
trunk/Source/WebKit2/ChangeLog
r109340 r109402 1 2012-03-01 Kangil Han <kangil.han@samsung.com> 2 3 [DRT] Remove all PlainTextController usages in existing tests by adding internal API 4 https://bugs.webkit.org/show_bug.cgi?id=78570 5 6 Reviewed by Hajime Morita. 7 8 This patch will remove all PlainTextController usages 9 in existing DRT tests by adding internal API to WebCore/testing/Internals 10 11 * win/WebKit2.def: 12 * win/WebKit2CFLite.def: 13 1 14 2012-03-01 Nikolas Zimmermann <nzimmermann@rim.com> 2 15 -
trunk/Source/WebKit2/win/WebKit2.def
r109096 r109402 194 194 ?shadowTree@Element@WebCore@@QBEPAVShadowTree@2@XZ 195 195 ?suggestedValue@HTMLInputElement@WebCore@@QBEABVString@WTF@@XZ 196 ?text@Range@WebCore@@QBE?AVString@WTF@@XZ 196 197 ?toDocument@WebCore@@YAPAVDocument@1@VJSValue@JSC@@@Z 197 198 ?toElement@WebCore@@YAPAVElement@1@VJSValue@JSC@@@Z -
trunk/Source/WebKit2/win/WebKit2CFLite.def
r109096 r109402 187 187 ?shadowTree@Element@WebCore@@QBEPAVShadowTree@2@XZ 188 188 ?suggestedValue@HTMLInputElement@WebCore@@QBEABVString@WTF@@XZ 189 ?text@Range@WebCore@@QBE?AVString@WTF@@XZ 189 190 ?toDocument@WebCore@@YAPAVDocument@1@VJSValue@JSC@@@Z 190 191 ?toElement@WebCore@@YAPAVElement@1@VJSValue@JSC@@@Z -
trunk/Source/autotools/symbols.filter
r109225 r109402 86 86 _ZNK7WebCore8Document8settingsEv; 87 87 _ZNK7WebCore8Document4viewEv; 88 _ZNK7WebCore5Range4textEv; 88 89 _ZNK7WebCore9TreeScope14getElementByIdERKN3WTF12AtomicStringE; 89 90 _ZNK7WebCore14DocumentMarker11descriptionEv;
Note: See TracChangeset
for help on using the changeset viewer.