Changeset 109424 in webkit

Timestamp:

Mar 1, 2012 2:24:52 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium
​https://bugs.webkit.org/show_bug.cgi?id=79714

Patch by James Robinson <​jamesr@chromium.org> on 2012-03-01
Reviewed by Adrienne Walker.

When the page scale changes on a composited layer we need to invalidate all of the contents on the layer in
order to repaint them at the new scale. The sequence of calls we get make this a bit tricky, since we first
receive a page scale changed notification and then receive the new layer bounds. The solution is to defer the
invalidation until we have the new layer bounds, which landed in r99774.

This moves that logic from LayerChromium into GraphicsLayerChromium since IMO this is pretty particular to the
way WebCore is passing us invalidations and not something fundamental to the compositor.

• platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):

• platform/graphics/chromium/GraphicsLayerChromium.h:
• platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):

• platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/GraphicsLayerChromium.cpp (modified) (3 diffs)
• platform/graphics/chromium/GraphicsLayerChromium.h (modified) (1 diff)
• platform/graphics/chromium/LayerChromium.cpp (modified) (2 diffs)
• platform/graphics/chromium/LayerChromium.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-01  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium
+        https://bugs.webkit.org/show_bug.cgi?id=79714
+
+        Reviewed by Adrienne Walker.
+
+        When the page scale changes on a composited layer we need to invalidate all of the contents on the layer in
+        order to repaint them at the new scale. The sequence of calls we get make this a bit tricky, since we first
+        receive a page scale changed notification and then receive the new layer bounds. The solution is to defer the
+        invalidation until we have the new layer bounds, which landed in r99774.
+
+        This moves that logic from LayerChromium into GraphicsLayerChromium since IMO this is pretty particular to the
+        way WebCore is passing us invalidations and not something fundamental to the compositor.
+
+        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
+        (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
+        (WebCore::GraphicsLayerChromium::setSize):
+        (WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):
+        * platform/graphics/chromium/GraphicsLayerChromium.h:
+        * platform/graphics/chromium/LayerChromium.cpp:
+        (WebCore::LayerChromium::LayerChromium):
+        (WebCore::LayerChromium::setBounds):
+        * platform/graphics/chromium/LayerChromium.h:
+        (LayerChromium):
+
 2012-03-01  Joe Thomas  <joethomas@motorola.com>
 

trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp

@@ -79 +79 @@
     , m_contentsLayerHasBackgroundColor(false)
     , m_inSetChildren(false)
+    , m_pageScaleChanged(false)
 {
     m_layer = ContentLayerChromium::create(this);
@@ -202 +203 @@
     GraphicsLayer::setSize(clampedSize);
     updateLayerSize();
+
+    if (m_pageScaleChanged && m_layer)
+        m_layer->setNeedsDisplay();
+    m_pageScaleChanged = false;
 }
 
@@ -723 +728 @@
 {
     updateContentsScale();
-    if (m_layer)
-        m_layer->pageScaleChanged();
+    // Invalidations are clamped to the layer's bounds but we receive the scale changed notification before receiving
+    // the new layer bounds. When the scale changes, we really want to invalidate the post-scale layer bounds, so we
+    // remember that the scale has changed and then invalidate the full layer bounds when we receive the new size.
+    m_pageScaleChanged = true;
 }
 

trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h

@@ -166 +166 @@
     bool m_contentsLayerHasBackgroundColor : 1;
     bool m_inSetChildren;
+    bool m_pageScaleChanged;
 
     AnimationIdMap m_animationIdMap;

trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp

@@ -85 +85 @@
     , m_targetRenderSurface(0)
     , m_contentsScale(1.0)
-    , m_pageScaleDirty(false)
     , m_layerAnimationDelegate(0)
 {
@@ -279 +278 @@
     m_bounds = size;
 
-    if (firstResize || m_pageScaleDirty)
+    if (firstResize)
         setNeedsDisplay();
     else
         setNeedsCommit();
-
-    m_pageScaleDirty = false;
 }
 

trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h

@@ -170 +170 @@
     virtual void unreserveContentsTexture() { }
     virtual void bindContentsTexture() { }
-    virtual void pageScaleChanged() { m_pageScaleDirty = true; }
     virtual void protectVisibleTileTextures() { }
     virtual bool needsContentsScale() const { return false; }
@@ -327 +326 @@
     String m_name;
 
-    bool m_pageScaleDirty;
-
     CCLayerAnimationDelegate* m_layerAnimationDelegate;
 };