Changeset 109486 in webkit

Timestamp:

Mar 1, 2012 7:11:56 PM (12 years ago)

Author:

andersca@apple.com

Message:

Crash when doing repeated double-tap-to-zoom gesture on apple startpage
​https://bugs.webkit.org/show_bug.cgi?id=80081
<rdar://problem/10966391>

Reviewed by Sam Weinig.

Setting the contents scale on the tile cache layer was creating a WebTileCacheLayer presentation layer copy with a null _tileCache.

Implement -[WebTileCacheLayer actionForKey:] and have it always return nil so we'll avoid implicit animations, and thus creating presentation layers.

• platform/graphics/ca/mac/WebTileCacheLayer.mm:

(-[WebTileCacheLayer initWithLayer:]):
Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer.

(-[WebTileCacheLayer actionForKey:]):
Implement this and always return nil.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ca/mac/WebTileCacheLayer.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-01  Anders Carlsson  <andersca@apple.com>
+
+        Crash when doing repeated double-tap-to-zoom gesture on apple startpage
+        https://bugs.webkit.org/show_bug.cgi?id=80081
+        <rdar://problem/10966391>
+
+        Reviewed by Sam Weinig.
+
+        Setting the contents scale on the tile cache layer was creating a WebTileCacheLayer presentation layer copy with a null _tileCache.
+
+        Implement -[WebTileCacheLayer actionForKey:] and have it always return nil so we'll avoid implicit animations, and thus creating presentation layers.
+
+        * platform/graphics/ca/mac/WebTileCacheLayer.mm:
+        (-[WebTileCacheLayer initWithLayer:]):
+        Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer.
+
+        (-[WebTileCacheLayer actionForKey:]):
+        Implement this and always return nil.
+
 2012-03-01  Hajime Morrita  <morrita@chromium.org>
 

trunk/Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.mm

@@ -57 +57 @@
 
     [super dealloc];
+}
+
+- (id)initWithLayer:(id)layer
+{
+    UNUSED_PARAM(layer);
+
+    ASSERT_NOT_REACHED();
+    return nil;
+}
+
+- (id<CAAction>)actionForKey:(NSString *)key
+{
+    UNUSED_PARAM(key);
+    
+    // Disable all animations.
+    return nil;
 }