Changeset 109606 in webkit

Timestamp:

Mar 2, 2012 1:13:19 PM (12 years ago)

Author:

dpranke@chromium.org

Message:

links for virtual tests are broken in the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=80180

Reviewed by Ojan Vafai.

• TestResultServer/static-dashboards/flakiness_dashboard.html:

(linkHTMLToOpenWindow):

• TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testLinkHTMLToOpenWindow): added.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestResultServer/static-dashboards/flakiness_dashboard.html (modified) (1 diff)
• TestResultServer/static-dashboards/flakiness_dashboard_tests.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-03-02  Dirk Pranke  <dpranke@chromium.org>
+
+        links for virtual tests are broken in the flakiness dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=80180
+
+        Reviewed by Ojan Vafai.
+
+        * TestResultServer/static-dashboards/flakiness_dashboard.html:
+        (linkHTMLToOpenWindow):
+        * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
+        (testLinkHTMLToOpenWindow): added.
+
 2012-03-02  Philippe Normand  <pnormand@igalia.com>
 

trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html

@@ -1175 +1175 @@
 function linkHTMLToOpenWindow(url, text)
 {
+    // FIXME: We probably need a more general way to map virtual tests
+    // to their underlying actual tests.
+    url = url.replace('platform/chromium/virtual/gpu/', '')
     return '<a href="' + url + '" target="_blank">' + text + '</a>';
 }

trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js

@@ -405 +405 @@
 }
 
+function testLinkHTMLToOpenWindow()
+{
+    var text = 'text';
+    // Test that we map regular tests and virtual tests properly.
+    self.assertEquals(linkHTMLToOpenWindow('http://localhost/fast/canvas/foo.html', text),
+                      '<a href="http://localhost/fast/canvas/foo.html" target="_blank">text</a>');
+    self.assertEquals(linkHTMLToOpenWindow('http://localhost/platform/chromium/virtual/gpu/fast/canvas/foo.html', text),
+                      '<a href="http://localhost/fast/canvas/foo.html" target="_blank">text</a>');
+}
+
 function runTests()
 {