Changeset 109612 in webkit


Ignore:
Timestamp:
Mar 2, 2012 1:59:06 PM (12 years ago)
Author:
dpranke@chromium.org
Message:

Layout issue with fieldset legend element
​https://bugs.webkit.org/show_bug.cgi?id=78684

Patch by SravanKumar Sandela <​ssandela@innominds.com> on 2012-03-02
Reviewed by Dirk Pranke.

Source/WebCore:

The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.

Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

LayoutTests:

  • fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.

Test case to check un-clipped border logic

  • platform/chromium/test_expectations.txt:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
Location:
trunk
Files:
3 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r109610 r109612  
     12012-03-02  SravanKumar Sandela  <ssandela@innominds.com>
     2
     3        Layout issue with fieldset legend element
     4        https://bugs.webkit.org/show_bug.cgi?id=78684
     5
     6        Reviewed by Dirk Pranke.
     7
     8        * fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.
     9
     10        Test case to check un-clipped border logic
     11
     12        * platform/chromium/test_expectations.txt:
     13        * platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
     14        * platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
     15
    1162012-03-02  Igor Oliveira  <igor.o@sisa.samsung.com>
    217

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r109604 r109612  
    43404340BUGCR83325 MAC DEBUG : platform/chromium/virtual/gpu/canvas/philip/tests/2d.imageData.put.created.html = PASS CRASH
    43414341BUGWK66908 : platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage.html = PASS TEXT
     4342
     4343//NEED REBASELINING
     4344BUGWK78684 : fast/block/basic/fieldset-stretch-to-legend.html = FAIL
     4345BUGWK78684 : fast/borders/fieldsetBorderRadius.html = FAIL
     4346BUGWK78684 : fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html = IMAGE IMAGE+TEXT

  • trunk/Source/WebCore/ChangeLog

    r109611 r109612  
     12012-03-02  SravanKumar Sandela  <ssandela@innominds.com>
     2
     3        Layout issue with fieldset legend element
     4        https://bugs.webkit.org/show_bug.cgi?id=78684
     5
     6        Reviewed by Dirk Pranke.
     7
     8        The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.
     9
     10        Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html
     11
     12        * rendering/RenderFieldset.cpp:
     13        (WebCore::RenderFieldset::paintBoxDecorations):
     14
    1152012-03-02  Erik Arvidsson  <arv@chromium.org>
    216

  • trunk/Source/WebCore/rendering/RenderFieldset.cpp

    r107880 r109612  
    159159    if (style()->isHorizontalWritingMode()) {
    160160        LayoutUnit clipTop = paintRect.y();
    161         LayoutUnit clipHeight = max(static_cast<LayoutUnit>(style()->borderTopWidth()), legend->height());
     161        LayoutUnit clipHeight = max(static_cast<LayoutUnit>(style()->borderTopWidth()), legend->height() - ((legend->height() - borderTop()) / 2));
    162162        graphicsContext->clipOut(LayoutRect(paintRect.x() + legend->x(), clipTop, legend->width(), clipHeight));
    163163    } else {
Note: See TracChangeset for help on using the changeset viewer.