Changeset 109811 in webkit


Ignore:
Timestamp:
Mar 5, 2012 4:13:51 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Tools: Correctly compute the positions of GestureScroll* events on
Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=80075

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-05
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::reset):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests: Correct a test to work the same on Gtk and non-Gtk chromium in
the presence of correctly synthesized GestureScroll* events.
​https://bugs.webkit.org/show_bug.cgi?id=80075

Patch by Robert Kroeger <​rjkroege@chromium.org> on 2012-03-05
Reviewed by Adam Barth.

  • fast/events/touch/gesture/gesture-scroll.html:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r109807 r109811  
     12012-03-05  Robert Kroeger  <rjkroege@chromium.org>
     2
     3        Correct a test to work the same on Gtk and non-Gtk chromium in
     4        the presence of correctly synthesized GestureScroll* events.
     5        https://bugs.webkit.org/show_bug.cgi?id=80075
     6
     7        Reviewed by Adam Barth.
     8
     9        * fast/events/touch/gesture/gesture-scroll.html:
     10
    1112012-03-05  Mihnea Ovidenie  <mihnea@adobe.com>
    212

  • trunk/LayoutTests/fast/events/touch/gesture/gesture-scroll.html

    r99258 r109811  
    99  position: relative;
    1010  background: white;
     11}
     12
     13::-webkit-scrollbar {
     14    width: 0px;
     15    height: 0px;
    1116}
    1217

  • trunk/Tools/ChangeLog

    r109810 r109811  
     12012-03-05  Robert Kroeger  <rjkroege@chromium.org>
     2
     3        Correctly compute the positions of GestureScroll* events on
     4        Chromium.
     5        https://bugs.webkit.org/show_bug.cgi?id=80075
     6
     7        Reviewed by Adam Barth.
     8
     9        * DumpRenderTree/chromium/EventSender.cpp:
     10        (EventSender::reset):
     11        (EventSender::gestureEvent):
     12        * DumpRenderTree/chromium/EventSender.h:
     13        (EventSender):
     14
    1152012-03-05  Dirk Pranke  <dpranke@chromium.org>
    216

  • trunk/Tools/DumpRenderTree/chromium/EventSender.cpp

    r109534 r109811  
    331331    touchPoints.clear();
    332332    m_taskList.revokeAll();
    333     m_gestureStartLocation = WebPoint(0, 0);
     333    m_currentGestureLocation = WebPoint(0, 0);
    334334}
    335335
    … …  
    11011101        event.deltaX = static_cast<float>(arguments[0].toDouble());
    11021102        event.deltaY = static_cast<float>(arguments[1].toDouble());
    1103         event.x = m_gestureStartLocation.x + event.deltaX;
    1104         event.y = m_gestureStartLocation.y + event.deltaY;
     1103        event.x = m_currentGestureLocation.x;
     1104        event.y = m_currentGestureLocation.y;
     1105        m_currentGestureLocation.x = m_currentGestureLocation.x + event.deltaX;
     1106        m_currentGestureLocation.y = m_currentGestureLocation.y + event.deltaY;
    11051107        break;
    11061108
    11071109    case WebInputEvent::GestureScrollBegin:
    1108         m_gestureStartLocation = WebPoint(point.x, point.y);
    1109         event.x = m_gestureStartLocation.x;
    1110         event.y = m_gestureStartLocation.y;
     1110        m_currentGestureLocation = WebPoint(point.x, point.y);
     1111        event.x = m_currentGestureLocation.x;
     1112        event.y = m_currentGestureLocation.y;
    11111113        break;
    11121114    case WebInputEvent::GestureScrollEnd:
    11131115        event.deltaX = static_cast<float>(arguments[0].toDouble());
    11141116        event.deltaY = static_cast<float>(arguments[1].toDouble());
    1115         event.x = m_gestureStartLocation.x;
    1116         event.y = m_gestureStartLocation.y;
     1117        event.x = m_currentGestureLocation.x;
     1118        event.y = m_currentGestureLocation.y;
    11171119        break;
    11181120    case WebInputEvent::GestureTap:

  • trunk/Tools/DumpRenderTree/chromium/EventSender.h

    r102424 r109811  
    163163
    164164    // Location of the touch point that initiated a gesture.
    165     WebKit::WebPoint m_gestureStartLocation;
     165    WebKit::WebPoint m_currentGestureLocation;
    166166
    167167    // Location of last mouseMoveTo event.
Note: See TracChangeset for help on using the changeset viewer.