Changeset 110061 in webkit
- Timestamp:
- Mar 7, 2012 9:15:07 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r110057 r110061 1 2012-03-07 ChangSeok Oh <shivamidow@gmail.com> 2 3 [EFL] Key press event is not processed properly. 4 https://bugs.webkit.org/show_bug.cgi?id=80491 5 6 Reviewed by Gustavo Noronha Silva. 7 8 This issue is related with mutation observer feature. 9 If enter key is pressed, then a keyboard event should be processed 10 and reach to the mutation observer, but it doesn't. 11 Some special keys like Enter, Backspace and Tab key should be processed 12 and change to a single character code, but EFL port hasn't handled like that. 13 14 At least we can verify this with following two tests as I know. but they require another 15 functionality for bug79601. I'm going to submit the patch for it after this one. 16 17 Test: fast/mutation/end-of-task-delivery.html 18 fast/mutation/inline-event-listener.html 19 20 * platform/efl/EflKeyboardUtilities.cpp: 21 (WebCore::singleCharacterString): 22 (WebCore): 23 * platform/efl/EflKeyboardUtilities.h: 24 (WebCore): 25 * platform/efl/PlatformKeyboardEventEfl.cpp: 26 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): 27 1 28 2012-03-07 Gavin Peters <gavinp@chromium.org> 2 29 -
trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp
r100726 r110061 178 178 } 179 179 180 String singleCharacterString(const String& keyName) 181 { 182 if (keyName == "Return") 183 return String("\r"); 184 if (keyName == "BackSpace") 185 return String("\x8"); 186 if (keyName == "Tab") 187 return String("\t"); 188 return keyName; 189 } 190 180 191 int windowsKeyCodeForEvasKeyName(String& keyName) 181 192 { -
trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h
r100726 r110061 36 36 37 37 WTF::String keyIdentifierForEvasKeyName(WTF::String&); 38 WTF::String singleCharacterString(const WTF::String&); 38 39 int windowsKeyCodeForEvasKeyName(WTF::String&); 39 40 -
trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp
r103181 r110061 43 43 PlatformKeyboardEvent::PlatformKeyboardEvent(const Evas_Event_Key_Down* event) 44 44 : PlatformEvent(PlatformEvent::KeyDown, evas_key_modifier_is_set(event->modifiers, "Shift"), evas_key_modifier_is_set(event->modifiers, "Control"), evas_key_modifier_is_set(event->modifiers, "Alt"), evas_key_modifier_is_set(event->modifiers, "Meta"), currentTime()) 45 , m_text( String::fromUTF8(event->string))46 , m_unmodifiedText( String::fromUTF8(event->string))45 , m_text(singleCharacterString(String::fromUTF8(event->string))) 46 , m_unmodifiedText(singleCharacterString(String::fromUTF8(event->string))) 47 47 { 48 48 String keyName = String(event->key); … … 57 57 PlatformKeyboardEvent::PlatformKeyboardEvent(const Evas_Event_Key_Up* event) 58 58 : PlatformEvent(PlatformEvent::KeyUp, evas_key_modifier_is_set(event->modifiers, "Shift"), evas_key_modifier_is_set(event->modifiers, "Control"), evas_key_modifier_is_set(event->modifiers, "Alt"), evas_key_modifier_is_set(event->modifiers, "Meta"), currentTime()) 59 , m_text( String::fromUTF8(event->string))59 , m_text(singleCharacterString(String::fromUTF8(event->string))) 60 60 { 61 61 String keyName = String(event->key);
Note: See TracChangeset
for help on using the changeset viewer.