Changeset 110064 in webkit

Timestamp:

Mar 7, 2012 9:27:15 AM (12 years ago)

Author:

Philippe Normand

Message:

[GTK] media/audio-garbage-collect.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=72698

Reviewed by Xan Lopez.

Source/WebCore:

Call ::hasPendingActivity() instead of ::paused() when checking if
the audio element is still active. This is similar to what the
image element (another ActiveDOMObject implementation) does just
above. This contributes to fixing the audio-garbage-collect.html
test.

• bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

LayoutTests:

• platform/gtk/test_expectations.txt: test is no longer flaky.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/js/JSNodeCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-07  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK] media/audio-garbage-collect.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=72698
+
+        Reviewed by Xan Lopez.
+
+        * platform/gtk/test_expectations.txt: test is no longer flaky.
+
 2012-03-07  Stephen White  <senorblanco@chromium.org>
 

trunk/LayoutTests/platform/gtk/test_expectations.txt

@@ -69 +69 @@
 BUGWK80129 : fast/frames/flattening/frameset-flattening-subframesets.html = PASS TEXT
 
-BUGWK72698 : media/audio-garbage-collect.html = PASS TEXT
 BUGWK79760 : media/video-poster-blocked-by-willsendrequest.html = PASS TEXT
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-07  Philippe Normand  <pnormand@igalia.com>
+
+        [GTK] media/audio-garbage-collect.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=72698
+
+        Reviewed by Xan Lopez.
+
+        Call ::hasPendingActivity() instead of ::paused() when checking if
+        the audio element is still active. This is similar to what the
+        image element (another ActiveDOMObject implementation) does just
+        above. This contributes to fixing the audio-garbage-collect.html
+        test.
+
+        * bindings/js/JSNodeCustom.cpp:
+        (WebCore::isReachableFromDOM):
+
 2012-03-07  Adele Peterson  <adele@apple.com>
 

trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp

@@ -117 +117 @@
     #if ENABLE(VIDEO)
         else if (node->hasTagName(audioTag)) {
-            if (!static_cast<HTMLAudioElement*>(node)->paused())
+            if (!static_cast<HTMLAudioElement*>(node)->hasPendingActivity())
                 return true;
         }