Changeset 110091 in webkit

Timestamp:

Mar 7, 2012 1:02:44 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

RenderImage ignores its percent width/height when setContainerSizeForRenderer
​https://bugs.webkit.org/show_bug.cgi?id=80431

Patch by Yong Li <​yoli@rim.com> on 2012-03-07
Reviewed by George Staikos.

Not only respect fixed width/height explicitly specified in img element, but also
respect percent width/height when determining container size for images.

No new tests because there is no functional change but only internal buffer sizes.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::computeReplacedLogicalWidth):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderImage.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-07  Yong Li  <yoli@rim.com>
+
+        RenderImage ignores its percent width/height when setContainerSizeForRenderer
+        https://bugs.webkit.org/show_bug.cgi?id=80431
+
+        Reviewed by George Staikos.
+
+        Not only respect fixed width/height explicitly specified in img element, but also
+        respect percent width/height when determining container size for images.
+
+        No new tests because there is no functional change but only internal buffer sizes.
+
+        * rendering/RenderImage.cpp:
+        (WebCore::RenderImage::computeReplacedLogicalWidth):
+
 2012-03-06  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebCore/rendering/RenderImage.cpp

@@ -505 +505 @@
 LayoutUnit RenderImage::computeReplacedLogicalWidth(bool includeMaxWidth) const
 {
-    // If we've got an explicit width/height assigned, propagate it to the image resource.    
-    if (style()->logicalWidth().isFixed() && style()->logicalHeight().isFixed()) {
+    // If we've got an explicit width/height assigned, propagate it to the image resource.
+    if (style()->logicalWidth().isSpecified() && style()->logicalHeight().isSpecified()) {
         LayoutUnit width = RenderReplaced::computeReplacedLogicalWidth(includeMaxWidth);
         m_imageResource->setContainerSizeForRenderer(IntSize(width, computeReplacedLogicalHeight()));