Changeset 110168 in webkit

Timestamp:

Mar 8, 2012 7:50:55 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Fix flaky test by decreasing granularity of cues (cues cover longer time
intervals). The flakiness seems to appear because the video is paused
synchronously, while missed events events are dispatched asynchronously.

It can happen that multiple cues are actually missed cues, hence more exit
events are dispatched together, but the video was paused before the actual
dispatch.

​https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-08
Reviewed by Eric Carlson.

• media/track/captions-webvtt/simple-captions.vtt:
• media/track/track-cues-pause-on-exit-expected.txt:
• media/track/track-cues-pause-on-exit.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/track/captions-webvtt/simple-captions.vtt (modified) (1 diff)
• media/track/track-cues-pause-on-exit-expected.txt (modified) (1 diff)
• media/track/track-cues-pause-on-exit.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-08  Victor Carbune  <vcarbune@adobe.com>
+
+        Fix flaky test by decreasing granularity of cues (cues cover longer time
+        intervals). The flakiness seems to appear because the video is paused
+        synchronously, while missed events events are dispatched asynchronously.
+
+        It can happen that multiple cues are actually missed cues, hence more exit
+        events are dispatched together, but the video was paused before the actual
+        dispatch.
+
+        https://bugs.webkit.org/show_bug.cgi?id=80067
+
+        Reviewed by Eric Carlson.
+
+        * media/track/captions-webvtt/simple-captions.vtt:
+        * media/track/track-cues-pause-on-exit-expected.txt:
+        * media/track/track-cues-pause-on-exit.html:
+
 2012-03-08  Ádám Kallai  <kadam@inf.u-szeged.hu>
 

trunk/LayoutTests/media/track/captions-webvtt/simple-captions.vtt

@@ -2 +2 @@
 
 0
-00:00:05.000 --> 00:00:05.200
+00:00:04.000 --> 00:00:04.500
 First cue
 
 1
-00:00:05.210 --> 00:00:05.400
+00:00:04.500 --> 00:00:05.000
 Lorem
 
 2
-00:00:05.410 --> 00:00:05.600
+00:00:05.000 --> 00:00:05.500
 ipsum
 
 3
-00:00:05.610 --> 00:00:05.700
-dolor
+00:00:05.500 --> 00:00:05.501
+Missed cue with pause-on-exit

trunk/LayoutTests/media/track/track-cues-pause-on-exit-expected.txt

@@ -24 +24 @@
 EXPECTED (currentCue.id == '3') OK
 EXPECTED (video.paused == 'false') OK
-EVENT(ended)
 END OF TEST
 

trunk/LayoutTests/media/track/track-cues-pause-on-exit.html

@@ -42 +42 @@
                 testExpected("video.paused", currentCueNumber % 2 == 0);
 
-                if (currentCueNumber % 2 == 0) {
+                if (currentCueNumber % 2 == 0)
                     run("video.play()");
-                }
+
+                if (currentCueNumber == 3)
+                    endTest();
 
                 currentCueNumber++;
@@ -62 +64 @@
             }
 
-            waitForEvent('ended', endTest);
-
             waitForEvent('canplaythrough', function() {
-                video.currentTime = 4.70;
+                video.currentTime = 4.00;
                 videoCanPlayThrough = true;