Changeset 110260 in webkit

Timestamp:

Mar 8, 2012 9:00:41 PM (12 years ago)

Author:

eae@chromium.org

Message:

Change calcRadiiFor to IntSize
​https://bugs.webkit.org/show_bug.cgi?id=80655

Reviewed by Simon Fraser.

Borders and RoundedRect are both represented with pixel precision. As
such it doesn't make sense for calcRadiiFor to use subpixel units, it
just adds unnecessary type conversions.

No new tests, no new functionality.

• rendering/style/RenderStyle.cpp:

(WebCore::calcRadiiFor):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/style/RenderStyle.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-08  Emil A Eklund  <eae@chromium.org>
+
+        Change calcRadiiFor to IntSize
+        https://bugs.webkit.org/show_bug.cgi?id=80655
+
+        Reviewed by Simon Fraser.
+
+        Borders and RoundedRect are both represented with pixel precision. As
+        such it doesn't make sense for calcRadiiFor to use subpixel units, it
+        just adds unnecessary type conversions.
+
+        No new tests, no new functionality.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::calcRadiiFor):
+
 2012-03-08  Adrienne Walker  <enne@google.com>
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -846 +846 @@
 {
     return RoundedRect::Radii(
-        LayoutSize(border.topLeft().width().calcValue(size.width()), 
-                   border.topLeft().height().calcValue(size.height())),
-        LayoutSize(border.topRight().width().calcValue(size.width()),
-                   border.topRight().height().calcValue(size.height())),
-        LayoutSize(border.bottomLeft().width().calcValue(size.width()), 
-                   border.bottomLeft().height().calcValue(size.height())),
-        LayoutSize(border.bottomRight().width().calcValue(size.width()), 
-                   border.bottomRight().height().calcValue(size.height())));
+        IntSize(border.topLeft().width().calcValue(size.width()), 
+                border.topLeft().height().calcValue(size.height())),
+        IntSize(border.topRight().width().calcValue(size.width()),
+                border.topRight().height().calcValue(size.height())),
+        IntSize(border.bottomLeft().width().calcValue(size.width()), 
+                border.bottomLeft().height().calcValue(size.height())),
+        IntSize(border.bottomRight().width().calcValue(size.width()), 
+                border.bottomRight().height().calcValue(size.height())));
 }