Changeset 110358 in webkit

Timestamp:

Mar 9, 2012 6:22:48 PM (12 years ago)

Author:

senorblanco@chromium.org

Message:

Improve ContainerNode collectNode() performance by reserving vector
capacity up front.
​https://bugs.webkit.org/show_bug.cgi?id=80706

Reviewed by Ryosuke Niwa.

Covered by existing tests. Performance will be evaluated based on
Chromium's page_cycler_bloat-http, page_cycler_intl1, and
dromaeo_domcore suites.

• dom/ContainerNode.cpp:

(WebCore::collectNodes):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ContainerNode.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-09  Stephen White  <senorblanco@chromium.org>
+
+        Improve ContainerNode collectNode() performance by reserving vector
+        capacity up front.
+        https://bugs.webkit.org/show_bug.cgi?id=80706
+
+        Reviewed by Ryosuke Niwa.
+
+        Covered by existing tests.  Performance will be evaluated based on
+        Chromium's page_cycler_bloat-http, page_cycler_intl1, and
+        dromaeo_domcore suites.
+
+        * dom/ContainerNode.cpp:
+        (WebCore::collectNodes):
+
 2012-03-09  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -27 +27 @@
 #include "ContainerNodeAlgorithms.h"
 #include "DeleteButtonController.h"
+#include "DocumentFragment.h"
 #include "EventNames.h"
 #include "ExceptionCode.h"
@@ -62 +63 @@
 static bool s_shouldReEnableMemoryCacheCallsAfterAttach;
 
-static inline void collectNodes(Node* node, NodeVector& nodes)
-{
+static inline void collectNodes(ContainerNode* node, NodeVector& nodes)
+{
+    nodes.reserveCapacity(nodes.size() + node->childNodeCount());
     for (Node* child = node->firstChild(); child; child = child->nextSibling())
         nodes.append(child);
@@ -74 +76 @@
         return;
     }
-    collectNodes(node, nodes);
+    collectNodes(static_cast<DocumentFragment*>(node), nodes);
 }