Changeset 110559 in webkit


Ignore:
Timestamp:
Mar 13, 2012 7:09:46 AM (12 years ago)
Author:
haraken@chromium.org
Message:

Dromaeo perf-tests results are wrong
https://bugs.webkit.org/show_bug.cgi?id=80974

Reviewed by Hajime Morita.

Dromaeo perf-tests had reported the sum of runs/seconds as "ms".
This patch fixes them to report the execution time per run.

At present, they report "0.0ms" for "stdev". This is because
dromaeorunner.js can just know stdev of "runs/seconds"
and cannot calculate stdev of "ms" from that. We can fix it later.

  • Dromaeo/resources/dromaeorunner.js:

(.):

Location:
trunk/PerformanceTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/PerformanceTests/ChangeLog

    r110421 r110559  
     12012-03-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        Dromaeo perf-tests results are wrong
     4        https://bugs.webkit.org/show_bug.cgi?id=80974
     5
     6        Reviewed by Hajime Morita.
     7
     8        Dromaeo perf-tests had reported the sum of runs/seconds as "ms".
     9        This patch fixes them to report the execution time per run.
     10
     11        At present, they report "0.0ms" for "stdev". This is because
     12        dromaeorunner.js can just know stdev of "runs/seconds"
     13        and cannot calculate stdev of "ms" from that. We can fix it later.
     14
     15        * Dromaeo/resources/dromaeorunner.js:
     16        (.):
     17
    1182012-03-12  Ilya Tikhonovsky  <loislo@chromium.org>
    219
  • trunk/PerformanceTests/Dromaeo/resources/dromaeorunner.js

    r106386 r110559  
    44
    55         computeScores: function (results) {
    6              var mean = 0, min = 0, max = 0, stdev = 0, varsum = 0;
     6             var mean = 0, min = 0, max = 0, median = 0;
    77
    88             for (var i = 0; i < results.length; ++i) {
    99                 var item = results[i];
    10                  mean += item.mean;
    11                  min += item.min;
    12                  max += item.max;
    13                  varsum += item.deviation * item.deviation;
     10                 if (item.mean == 0 || item.max == 0 || item.min == 0 || item.median == 0)
     11                     return {median: 0, mean: 0, min: 0, max: 0, stdev: 0};
     12
     13                 mean += 1000 / item.mean;
     14                 min += 1000 / item.max;
     15                 max += 1000 / item.min;
     16                 median += 1000 / item.median;
    1417             }
    1518
    1619             return {
    17                  median: 0,
     20                 median: median,
    1821                 mean: mean,
    1922                 min: min,
    2023                 max: max,
    21                  stdev: Math.sqrt(varsum)
     24                 stdev: 0
    2225             };
    2326         },
Note: See TracChangeset for help on using the changeset viewer.