Changeset 110594 in webkit


Ignore:
Timestamp:
Mar 13, 2012 1:05:01 PM (12 years ago)
Author:
tonikitoo@webkit.org
Message:

Convert nodesFromRect tests to use Internals interface
​https://bugs.webkit.org/show_bug.cgi?id=80886

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <​agomes@rim.com>

Source/WebCore:

Add Internals::nodesFromRect implementation to unify
the codepath for testing Document::nodesFromRect in a
cross port way.

No new tests, since we are improving here the infra-structure
for testing a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/gtk:

Removed DRTSupportGtk::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Removed mac specific support for nodesFromRect for testing purposes only,
since it can work in a cross-port way through the Internals interface.

  • WebKit.order:
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

Removed DRTSupportQt::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

This clean up allows to remove port specific bits of each
DRT implementation that supports testing Document::nodesFromRect,
in favor of making use of the 'Internals' interface to test it.

This makes its code conveniently more expansible and cleaner.

Also removed stubs from Win and EFL, Wn and BlackBerry DRTs.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

LayoutTests:

Adjust nodesFromRect tests to use Internals
instead of LayoutTestController interface.

  • fast/dom/resources/nodesFromRect.js:

(check):

Location:
trunk
Files:
29 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r110593 r110594  
     12012-03-12  Antonio Gomes  <agomes@rim.com>
     2
     3        Convert nodesFromRect tests to use Internals interface
     4        https://bugs.webkit.org/show_bug.cgi?id=80886
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Adjust nodesFromRect tests to use Internals
     9        instead of LayoutTestController interface.
     10
     11        * fast/dom/resources/nodesFromRect.js:
     12        (check):
     13
    1142012-03-13  Philip Rogers  <pdr@google.com>
    215

  • trunk/LayoutTests/fast/dom/resources/nodesFromRect.js

    r98407 r110594  
    66function check(x, y, topPadding, rightPadding, bottomPadding, leftPadding, list, doc)
    77{
    8   if (!window.layoutTestController)
     8  if (!window.internals)
    99    return;
    1010
    … …  
    1212    doc = document;
    1313
    14   var nodes = layoutTestController.nodesFromRect(doc, x, y, topPadding, rightPadding, bottomPadding, leftPadding, true /* ignoreClipping */);
     14  var nodes = internals.nodesFromRect(doc, x, y, topPadding, rightPadding, bottomPadding, leftPadding, true /* ignoreClipping */);
    1515  if (!nodes)
    1616    return;

  • trunk/Source/WebCore/ChangeLog

    r110593 r110594  
     12012-03-12  Antonio Gomes  <agomes@rim.com>
     2
     3        Convert nodesFromRect tests to use Internals interface
     4        https://bugs.webkit.org/show_bug.cgi?id=80886
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Add Internals::nodesFromRect implementation to unify
     9        the codepath for testing Document::nodesFromRect in a
     10        cross port way.
     11
     12        No new tests, since we are improving here the infra-structure
     13        for testing a specific method.
     14
     15        * testing/Internals.cpp:
     16        (WebCore::Internals::nodesFromRect):
     17        (WebCore):
     18        * testing/Internals.h:
     19        (Internals):
     20        * testing/Internals.idl:
     21
    1222012-03-13  Philip Rogers  <pdr@google.com>
    223

  • trunk/Source/WebCore/testing/Internals.cpp

    r110580 r110594  
    693693}
    694694
    695 }
     695PassRefPtr<NodeList> Internals::nodesFromRect(Document* document, int x, int y, unsigned topPadding, unsigned rightPadding,
     696    unsigned bottomPadding, unsigned leftPadding, bool ignoreClipping, ExceptionCode& ec) const
     697{
     698    if (!document || !document->frame() || !document->frame()->view()) {
     699        ec = INVALID_ACCESS_ERR;
     700        return 0;
     701    }
     702
     703    return document->nodesFromRect(x, y, topPadding, rightPadding, bottomPadding, leftPadding, ignoreClipping);
     704}
     705
     706}

  • trunk/Source/WebCore/testing/Internals.h

    r110580 r110594  
    2828
    2929#include "FrameDestructionObserver.h"
     30#include "NodeList.h"
    3031#include "PlatformString.h"
    3132#include <wtf/PassRefPtr.h>
    … …  
    126127    unsigned touchEventHandlerCount(Document*, ExceptionCode&);
    127128
     129    PassRefPtr<NodeList> nodesFromRect(Document*, int x, int y, unsigned topPadding, unsigned rightPadding,
     130        unsigned bottomPadding, unsigned leftPadding, bool ignoreClipping, ExceptionCode&) const;
     131
    128132    static const char* internalsId;
    129133

  • trunk/Source/WebCore/testing/Internals.idl

    r110580 r110594  
    102102        unsigned long touchEventHandlerCount(in Document document) raises (DOMException);
    103103
     104        NodeList nodesFromRect(in Document document, in long x, in long y,
     105            in unsigned long topPadding, in unsigned long rightPadding, in unsigned long bottomPadding, in unsigned long leftPadding,
     106            in boolean ignoreClipping) raises (DOMException);
     107
    104108        readonly attribute InternalSettings settings;
    105109    };

  • trunk/Source/WebKit/gtk/ChangeLog

    r110032 r110594  
     12012-03-12  Antonio Gomes  <agomes@rim.com>
     2
     3        Convert nodesFromRect tests to use Internals interface
     4        https://bugs.webkit.org/show_bug.cgi?id=80886
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Removed DRTSupportGtk::nodesFromRect support, since
     9        it can work in the cross-port way through the
     10        Internals interface.
     11
     12        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
     13        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
     14        (DumpRenderTreeSupportGtk):
     15
    1162012-03-07  Kangil Han  <kangil.han@samsung.com>
    217

  • trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

    r110032 r110594  
    114114}
    115115
    116 JSValueRef DumpRenderTreeSupportGtk::nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
    117 {
    118     JSLock lock(SilenceAssertionsOnly);
    119     ExecState* exec = toJS(context);
    120     if (!value)
    121         return JSValueMakeUndefined(context);
    122     JSValue jsValue = toJS(exec, value);
    123     if (!jsValue.inherits(&JSDocument::s_info))
    124        return JSValueMakeUndefined(context);
    125 
    126     JSDocument* jsDocument = static_cast<JSDocument*>(asObject(jsValue));
    127     Document* document = jsDocument->impl();
    128     RefPtr<NodeList> nodes = document->nodesFromRect(x, y, top, right, bottom, left, ignoreClipping);
    129     return toRef(exec, toJS(exec, jsDocument->globalObject(), nodes.get()));
    130 }
    131 
    132116/**
    133117 * getFrameChildren:

  • trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

    r110032 r110594  
    5454    static bool selectTrailingWhitespaceEnabled();
    5555
    56     static JSValueRef nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping);
    5756    static void dumpConfigurationForViewport(WebKitWebView* webView, gint deviceDPI, gint deviceWidth, gint deviceHeight, gint availableWidth, gint availableHeight);
    5857

  • trunk/Source/WebKit/mac/ChangeLog

    r110586 r110594  
     12012-03-12  Antonio Gomes  <agomes@rim.com>
     2
     3        Convert nodesFromRect tests to use Internals interface
     4        https://bugs.webkit.org/show_bug.cgi?id=80886
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Removed mac specific support for nodesFromRect for testing purposes only,
     9        since it can work in a cross-port way through the Internals interface.
     10
     11        * WebKit.order:
     12        * WebView/WebView.mm:
     13        * WebView/WebViewPrivate.h:
     14
    1152012-03-13  Anders Carlsson  <andersca@apple.com>
    216

  • trunk/Source/WebKit/mac/WebKit.order

    r107682 r110594  
    18161816-[WebView(WebIBActions) stopLoading:]
    18171817-[WebView(WebPrivate) _closeWindow]
    1818 -[WebView(WebViewPrivateNodesFromRect) _nodesFromRect:forDocument:x:y:top:right:bottom:left:ignoreClipping:]
    18191818__ZN20WebFrameLoaderClient38dispatchDecidePolicyForNewWindowActionEMN7WebCore13PolicyCheckerEFvNS0_12PolicyActionEERKNS0_16NavigationActionERKNS0_15ResourceRequestEN3WTF10PassRefPtrINS0_9FormStateEEERKNSB_6StringE
    18201819-[WebDefaultPolicyDelegate webView:decidePolicyForNewWindowAction:request:newFrameName:decisionListener:]

  • trunk/Source/WebKit/mac/WebView/WebView.mm

    r110216 r110594  
    64626462@end
    64636463
    6464 @implementation WebView (WebViewPrivateNodesFromRect)
    6465 
    6466 - (JSValueRef)_nodesFromRect:(JSContextRef)context forDocument:(JSValueRef)value x:(int)x  y:(int)y top:(unsigned)top right:(unsigned)right bottom:(unsigned)bottom left:(unsigned)left ignoreClipping:(BOOL)ignoreClipping
    6467 {
    6468     JSLock lock(SilenceAssertionsOnly);
    6469     ExecState* exec = toJS(context);
    6470     if (!value)
    6471         return JSValueMakeUndefined(context);
    6472     JSValue jsValue = toJS(exec, value);
    6473     if (!jsValue.inherits(&JSDocument::s_info))
    6474         return JSValueMakeUndefined(context);
    6475     JSDocument* jsDocument = static_cast<JSDocument*>(asObject(jsValue));
    6476     Document* document = jsDocument->impl();
    6477     RefPtr<NodeList> nodes = document->nodesFromRect(x, y, top, right, bottom, left, ignoreClipping);
    6478     return toRef(exec, toJS(exec, jsDocument->globalObject(), nodes.get()));
    6479 }
    6480 
    6481 @end
    6482 
    64836464void WebInstallMemoryPressureHandler(void)
    64846465{

  • trunk/Source/WebKit/mac/WebView/WebViewPrivate.h

    r110381 r110594  
    748748@end
    749749
    750 @interface WebView (WebViewPrivateNodesFromRect)
    751 - (JSValueRef)_nodesFromRect:(JSContextRef)context forDocument:(JSValueRef)value x:(int)x  y:(int)y top:(unsigned)top right:(unsigned)right bottom:(unsigned)bottom left:(unsigned)left ignoreClipping:(BOOL)ignoreClipping;
    752 @end
    753 
    754750@interface NSObject (WebViewFrameLoadDelegatePrivate)
    755751- (void)webView:(WebView *)sender didFirstLayoutInFrame:(WebFrame *)frame;

  • trunk/Source/WebKit/qt/ChangeLog

    r110381 r110594  
     12012-03-12  Antonio Gomes  <agomes@rim.com>
     2
     3        Convert nodesFromRect tests to use Internals interface
     4        https://bugs.webkit.org/show_bug.cgi?id=80886
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Removed DRTSupportQt::nodesFromRect support, since
     9        it can work in the cross-port way through the
     10        Internals interface.
     11
     12        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
     13        * WebCoreSupport/DumpRenderTreeSupportQt.h:
     14
    1152012-03-09  Jon Lee  <jonlee@apple.com>
    216

  • trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp

    r110032 r110594  
    993993}
    994994
    995 QVariantList DumpRenderTreeSupportQt::nodesFromRect(const QWebElement& document, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
    996 {
    997     QVariantList res;
    998     WebCore::Element* webElement = document.m_element;
    999     if (!webElement)
    1000         return res;
    1001 
    1002     Document* doc = webElement->document();
    1003     if (!doc)
    1004         return res;
    1005     RefPtr<NodeList> nodes = doc->nodesFromRect(x, y, top, right, bottom, left, ignoreClipping);
    1006     for (unsigned i = 0; i < nodes->length(); i++) {
    1007         // QWebElement will be null if the Node is not an HTML Element
    1008         if (nodes->item(i)->isHTMLElement())
    1009             res << QVariant::fromValue(QWebElement(nodes->item(i)));
    1010         else
    1011             res << QVariant::fromValue(QDRTNode(nodes->item(i)));
    1012     }
    1013     return res;
    1014 }
    1015 
    1016995void DumpRenderTreeSupportQt::setDefersLoading(QWebPage* page, bool flag)
    1017996{

  • trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h

    r110032 r110594  
    207207    static void scalePageBy(QWebFrame*, float scale, const QPoint& origin);
    208208
    209     static QVariantList nodesFromRect(const QWebElement& document, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping);
    210209    static QString responseMimeType(QWebFrame*);
    211210    static void clearOpener(QWebFrame*);

  • trunk/Source/WebKit2/win/WebKit2.def

    r110580 r110594  
    205205        ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z
    206206        ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVRange@1@@Z
     207        ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNodeList@1@@Z
    207208        ?toRange@WebCore@@YAPAVRange@1@VJSValue@JSC@@@Z
    208209        ?updateLayoutIgnorePendingStylesheets@Document@WebCore@@QAEXXZ
    … …  
    210211        ?view@Document@WebCore@@QBEPAVFrameView@2@XZ
    211212        ?willDetachPage@FrameDestructionObserver@WebCore@@UAEXXZ
     213        ?nodesFromRect@Document@WebCore@@QBE?AV?$PassRefPtr@VNodeList@WebCore@@@WTF@@HHIIII_N@Z

  • trunk/Source/autotools/symbols.filter

    r110580 r110594  
    108108_ZN7WebCore22RuntimeEnabledFeatures32setMultipleShadowSubtreesEnabledEb;
    109109_ZN7WebCore22RuntimeEnabledFeatures18isShadowDOMEnabledE;
     110_ZNK7WebCore8Document13nodesFromRectEiijjjjb;
     111_ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_8NodeListE;
    110112local:
    111113_Z*;

  • trunk/Tools/ChangeLog

    r110585 r110594  
     12012-03-12  Antonio Gomes  <agomes@rim.com>
     2
     3        Convert nodesFromRect tests to use Internals interface
     4        https://bugs.webkit.org/show_bug.cgi?id=80886
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        This clean up allows to remove port specific bits of each
     9        DRT implementation that supports testing Document::nodesFromRect,
     10        in favor of making use of the 'Internals' interface to test it.
     11
     12        This makes its code conveniently more expansible and cleaner.
     13
     14        Also removed stubs from Win and EFL DRTs.
     15
     16        * DumpRenderTree/LayoutTestController.cpp:
     17        (LayoutTestController::staticFunctions):
     18        * DumpRenderTree/LayoutTestController.h:
     19        (LayoutTestController):
     20        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
     21        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     22        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
     23        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
     24        * DumpRenderTree/qt/LayoutTestControllerQt.h:
     25        (LayoutTestController):
     26        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
     27
    1282012-03-13  Ojan Vafai  <ojan@chromium.org>
    229

  • trunk/Tools/DumpRenderTree/LayoutTestController.cpp

    r109892 r110594  
    748748}
    749749
    750 static JSValueRef nodesFromRectCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
    751 {
    752     if (argumentCount != 8)
    753         return JSValueMakeUndefined(context);
    754 
    755     int x = JSValueToNumber(context, arguments[1], NULL);
    756     int y = JSValueToNumber(context, arguments[2], NULL);
    757     int top = static_cast<unsigned>(JSValueToNumber(context, arguments[3], NULL));
    758     int right = static_cast<unsigned>(JSValueToNumber(context, arguments[4], NULL));
    759     int bottom = static_cast<unsigned>(JSValueToNumber(context, arguments[5], NULL));
    760     int left = static_cast<unsigned>(JSValueToNumber(context, arguments[6], NULL));
    761     bool ignoreClipping = JSValueToBoolean(context, arguments[7]);
    762 
    763     // Has mac implementation.
    764     LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));
    765     return controller->nodesFromRect(context, arguments[0], x, y, top, right, bottom, left, ignoreClipping);
    766 }
    767 
    768750static JSValueRef layerTreeAsTextCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
    769751{
    … …  
    23542336        { "closeWebInspector", closeWebInspectorCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    23552337        { "computedStyleIncludingVisitedInfo", computedStyleIncludingVisitedInfoCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    2356         { "nodesFromRect", nodesFromRectCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    23572338        { "decodeHostName", decodeHostNameCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    23582339        { "disableImageLoading", disableImageLoadingCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },

  • trunk/Tools/DumpRenderTree/LayoutTestController.h

    r107682 r110594  
    7070    void keepWebHistory();
    7171    JSValueRef computedStyleIncludingVisitedInfo(JSContextRef, JSValueRef);
    72     JSValueRef nodesFromRect(JSContextRef, JSValueRef, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping);
    7372    void notifyDone();
    7473    int numberOfPages(float pageWidthInPixels, float pageHeightInPixels);

  • trunk/Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp

    r109749 r110594  
    724724}
    725725
    726 JSValueRef LayoutTestController::nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
    727 {
    728     notImplemented();
    729     return JSValueMakeUndefined(context);
    730 }
    731 
    732726void LayoutTestController::setSerializeHTTPLoads(bool)
    733727{

  • trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

    r110028 r110594  
    110110}
    111111
    112 JSValueRef LayoutTestController::nodesFromRect(JSContextRef context, JSValueRef, int, int, unsigned, unsigned, unsigned, unsigned, bool)
    113 {
    114     notImplemented();
    115     return JSValueMakeUndefined(context);
    116 }
    117 
    118112JSRetainPtr<JSStringRef> LayoutTestController::layerTreeAsText() const
    119113{

  • trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r109753 r110594  
    123123    // FIXME: Implement this.
    124124    return JSValueMakeUndefined(context);
    125 }
    126 
    127 JSValueRef LayoutTestController::nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
    128 {
    129     return DumpRenderTreeSupportGtk::nodesFromRect(context, value, x, y, top, right, bottom, left, ignoreClipping);
    130125}
    131126

  • trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm

    r107682 r110594  
    277277}
    278278
    279 JSValueRef LayoutTestController::nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
    280 {
    281     return [[mainFrame webView] _nodesFromRect:context forDocument:value x:x y:y top:top right:right bottom:bottom left:left ignoreClipping:ignoreClipping];
    282 }
    283 
    284279JSRetainPtr<JSStringRef> LayoutTestController::layerTreeAsText() const
    285280{

  • trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

    r108505 r110594  
    950950}
    951951
    952 QVariantList LayoutTestController::nodesFromRect(const QWebElement& document, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
    953 {
    954     return DumpRenderTreeSupportQt::nodesFromRect(document, x, y, top, right, bottom, left, ignoreClipping);
    955 }
    956 
    957952void LayoutTestController::addURLToRedirect(const QString& origin, const QString& destination)
    958953{

  • trunk/Tools/DumpRenderTree/qt/LayoutTestControllerQt.h

    r107682 r110594  
    244244    bool hasSpellingMarker(int from, int length);
    245245
    246     QVariantList nodesFromRect(const QWebElement& document, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping);
    247 
    248246    void addURLToRedirect(const QString& origin, const QString& destination);
    249247

  • trunk/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp

    r110523 r110594  
    180180}
    181181
    182 JSValueRef LayoutTestController::nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
    183 {
    184     // FIXME: Implement this.
    185     return JSValueMakeUndefined(context);
    186 }
    187 
    188182JSRetainPtr<JSStringRef> LayoutTestController::layerTreeAsText() const
    189183{

  • trunk/Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp

    r107682 r110594  
    538538}
    539539
    540 JSValueRef LayoutTestController::nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping)
     540void LayoutTestController::authenticateSession(JSStringRef, JSStringRef, JSStringRef)
     541{
     542}
     543
     544void LayoutTestController::setEditingBehavior(const char* editingBehavior)
     545{
     546    // FIXME: Implement
     547}
     548
     549void LayoutTestController::abortModal()
     550{
     551}
     552
     553bool LayoutTestController::hasSpellingMarker(int, int)
     554{
     555    // FIXME: Implement
     556    return false;
     557}
     558
     559bool LayoutTestController::hasGrammarMarker(int, int)
     560{
     561    // FIXME: Implement
     562    return false;
     563}
     564
     565void LayoutTestController::dumpConfigurationForViewport(int /*deviceDPI*/, int /*deviceWidth*/, int /*deviceHeight*/, int /*availableWidth*/, int /*availableHeight*/)
     566{
     567    // FIXME: Implement
     568}
     569
     570JSRetainPtr<JSStringRef> LayoutTestController::pageProperty(const char* propertyName, int pageNumber) const
     571{
     572    // FIXME: Implement
     573    return 0;
     574}
     575
     576bool LayoutTestController::isPageBoxVisible(int pageNumber) const
     577{
     578    // FIXME: Implement
     579    return true;
     580}
     581
     582JSRetainPtr<JSStringRef> LayoutTestController::pageSizeAndMarginsInPixels(int pageNumber, int width, int height, int marginTop, int marginRight, int marginBottom, int marginLeft) const
     583{
     584    // FIXME: Implement
     585    return 0;
     586}
     587
     588void LayoutTestController::setAsynchronousSpellCheckingEnabled(bool)
    541589{
    542590    // FIXME: Implement this.
    543     return 0;
    544 }
    545 
    546 void LayoutTestController::authenticateSession(JSStringRef, JSStringRef, JSStringRef)
    547 {
    548 }
    549 
    550 void LayoutTestController::setEditingBehavior(const char* editingBehavior)
    551 {
    552     // FIXME: Implement
    553 }
    554 
    555 void LayoutTestController::abortModal()
    556 {
    557 }
    558 
    559 bool LayoutTestController::hasSpellingMarker(int, int)
    560 {
    561     // FIXME: Implement
    562     return false;
    563 }
    564 
    565 bool LayoutTestController::hasGrammarMarker(int, int)
    566 {
    567     // FIXME: Implement
    568     return false;
    569 }
    570 
    571 void LayoutTestController::dumpConfigurationForViewport(int /*deviceDPI*/, int /*deviceWidth*/, int /*deviceHeight*/, int /*availableWidth*/, int /*availableHeight*/)
    572 {
    573     // FIXME: Implement
    574 }
    575 
    576 JSRetainPtr<JSStringRef> LayoutTestController::pageProperty(const char* propertyName, int pageNumber) const
    577 {
    578     // FIXME: Implement
    579     return 0;
    580 }
    581 
    582 bool LayoutTestController::isPageBoxVisible(int pageNumber) const
    583 {
    584     // FIXME: Implement
    585     return true;
    586 }
    587 
    588 JSRetainPtr<JSStringRef> LayoutTestController::pageSizeAndMarginsInPixels(int pageNumber, int width, int height, int marginTop, int marginRight, int marginBottom, int marginLeft) const
    589 {
    590     // FIXME: Implement
    591     return 0;
    592 }
    593 
    594 void LayoutTestController::setAsynchronousSpellCheckingEnabled(bool)
    595 {
    596     // FIXME: Implement this.
    597591}
    598592
Note: See TracChangeset for help on using the changeset viewer.