Changeset 110619 in webkit

Timestamp:

Mar 13, 2012 2:59:21 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][DRT] Expose window.internals object
​https://bugs.webkit.org/show_bug.cgi?id=79900

Exposes window.internals for EFL's DRT. Makes possible to
remove some tests from the skip list.

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-03-13
Reviewed by Antonio Gomes.

Tools:

• DumpRenderTree/efl/CMakeLists.txt:
• DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWindowObjectCleared):

LayoutTests:

• platform/efl/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/efl/CMakeLists.txt (modified) (2 diffs)
• Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
+
+        [EFL][DRT] Expose window.internals object
+        https://bugs.webkit.org/show_bug.cgi?id=79900
+
+        Exposes window.internals for EFL's DRT. Makes possible to
+        remove some tests from the skip list.
+
+        Reviewed by Antonio Gomes.
+
+        * platform/efl/Skipped:
+
 2012-03-13  Adam Barth  <abarth@webkit.org>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -290 +290 @@
 fast/media/print-restores-previous-mediatype.html
 
-# EFL's LayoutTestController does not implement shadowRoot
-editing/text-iterator/range-to-from-location-and-length.html
-fast/css/webkit-mask-crash-fieldset-legend.html
-fast/css/webkit-mask-crash-figure.html
-fast/css/webkit-mask-crash-table.html
-fast/css/webkit-mask-crash-td.html
-fast/css/webkit-mask-crash-td-2.html
-fast/dom/HTMLKeygenElement/keygen.html
-fast/dom/HTMLMeterElement/meter-clone.html
-fast/dom/HTMLMeterElement/meter-element-markup.html
-fast/dom/HTMLProgressElement/progress-clone.html
-fast/dom/HTMLProgressElement/progress-element-markup.html
-fast/dom/scroll-element-to-rect-centered.html
-fast/dom/scroll-element-to-rect.html
+# ENABLE(SHADOW_DOM) is disabled
 fast/dom/shadow
-fast/forms/file/file-style-inheritance.html
-fast/forms/file/input-file-label.html
-fast/forms/suggested-value-after-setvalue.html
-fast/forms/suggested-value.html
-fast/forms/textfield-lastchange-was-useredit.html
-fast/forms/validation-message-clone.html
-fast/forms/validation-message-on-checkbox.html
-fast/forms/validation-message-on-listbox.html
-fast/forms/validation-message-on-menulist.html
-fast/forms/validation-message-on-radio.html
-fast/forms/validation-message-on-textarea.html
+
 fast/forms/color/input-color-onchange-event.html
-fast/harness/internals-object.html
-fast/html/clone-keygen.html
-fast/html/clone-range.html
 fast/html/details-clone.html
-fast/parser/object-with-textarea-fallback.html
-fast/preloader/scan-body-from-head-import.html
-fast/preloader/scan-body-from-head-script.html
-fullscreen/video-controls-override.html
-media/audio-controls-do-not-fade-out.html
-media/audio-delete-while-slider-thumb-clicked.html
-media/controls-drag-timebar.html
-media/media-controls-invalid-url.html
-media/video-controls-visible-audio-only.html
 
 # EFL's LayoutTestController does not implement nodesFromRect

trunk/Tools/ChangeLog

@@ +1 @@
+2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
+
+        [EFL][DRT] Expose window.internals object
+        https://bugs.webkit.org/show_bug.cgi?id=79900
+
+        Exposes window.internals for EFL's DRT. Makes possible to
+        remove some tests from the skip list.
+
+        Reviewed by Antonio Gomes.
+
+        * DumpRenderTree/efl/CMakeLists.txt:
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::onWindowObjectCleared):
+
 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Tools/DumpRenderTree/efl/CMakeLists.txt

@@ -25 +25 @@
 SET(DumpRenderTree_LIBRARIES
     ${JavaScriptCore_LIBRARY_NAME}
+    ${WebCoreTestSupport_LIBRARY_NAME}
     ${WebCore_LIBRARY_NAME}
     ${WebKit_LIBRARY_NAME}
@@ -89 +90 @@
     ${DERIVED_SOURCES_WEBCORE_DIR}
     ${WEBCORE_DIR}/bindings/js
+    ${WEBCORE_DIR}/testing/js
     ${Cairo_INCLUDE_DIRS}
     ${EDJE_INCLUDE_DIRS}

trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

@@ -35 +35 @@
 #include "NotImplemented.h"
 #include "WebCoreSupport/DumpRenderTreeSupportEfl.h"
+#include "WebCoreTestSupport.h"
 #include "WorkQueue.h"
 #include "ewk_private.h" // FIXME: create some WebCoreSupport/DumpRenderTree.cpp instead
@@ -211 +212 @@
                         makeEventSender(objectClearedInfo->context, !DumpRenderTreeSupportEfl::frameParent(objectClearedInfo->frame)),
                         kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete, 0);
+
+    WebCoreTestSupport::injectInternalsObject(objectClearedInfo->context);
 }