Changeset 110956 in webkit
- Timestamp:
- Mar 16, 2012 12:34:51 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r110955 r110956 1 2012-03-16 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r110951. 4 http://trac.webkit.org/changeset/110951 5 https://bugs.webkit.org/show_bug.cgi?id=81316 6 7 Does not build on apple-mac (Requested by abarth on #webkit). 8 9 * webaudio/dynamicscompressor-basic-expected.txt: 10 * webaudio/dynamicscompressor-basic.html: 11 1 12 2012-03-16 Mike Reed <reed@google.com> 2 13 -
trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt
r110951 r110956 6 6 PASS knee attribute has correct default value. 7 7 PASS ratio attribute has correct default value. 8 PASS attack attribute has correct default value.9 PASS release attribute has correct default value.10 8 PASS successfullyParsed is true 11 9 -
trunk/LayoutTests/webaudio/dynamicscompressor-basic.html
r110951 r110956 44 44 testFailed("ratio attribute has incorrect default value."); 45 45 46 if (compressor.attack.value - 0.003 < 1e-7)47 testPassed("attack attribute has correct default value.");48 else49 testFailed("attack attribute has incorrect default value.");50 51 if (compressor.release.value - 0.25 < 1e-7)52 testPassed("release attribute has correct default value.");53 else54 testFailed("release attribute has incorrect default value.");55 56 46 } catch(e) { 57 47 testFailed("Exception thrown when accessing DynamicsCompressorNode attributes."); -
trunk/Source/WebCore/ChangeLog
r110953 r110956 1 2012-03-16 Sheriff Bot <webkit.review.bot@gmail.com> 2 3 Unreviewed, rolling out r110951. 4 http://trac.webkit.org/changeset/110951 5 https://bugs.webkit.org/show_bug.cgi?id=81316 6 7 Does not build on apple-mac (Requested by abarth on #webkit). 8 9 * platform/audio/DynamicsCompressor.h: 10 (DynamicsCompressor): 11 * webaudio/DynamicsCompressorNode.cpp: 12 (WebCore::DynamicsCompressorNode::DynamicsCompressorNode): 13 (WebCore::DynamicsCompressorNode::process): 14 * webaudio/DynamicsCompressorNode.h: 15 (DynamicsCompressorNode): 16 * webaudio/DynamicsCompressorNode.idl: 17 1 18 2012-03-16 Seo Sanghyeon <sh4.seo@samsung.com> 2 19 -
trunk/Source/WebCore/platform/audio/DynamicsCompressor.h
r110951 r110956 86 86 87 87 // m_parameters holds the tweakable compressor parameters. 88 // FIXME: expose some of the most important ones (such as threshold, attack, release) 89 // as DynamicsCompressorNode attributes. 88 90 float m_parameters[ParamLast]; 89 91 void initializeParameters(); -
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.cpp
r110951 r110956 51 51 m_ratio = AudioParam::create("ratio", 12, 1, 20); 52 52 m_reduction = AudioParam::create("reduction", 0, -20, 0); 53 m_attack = AudioParam::create("attack", 0.003, 0, 1);54 m_release = AudioParam::create("release", 0.250, 0, 1);55 53 56 54 m_threshold->setContext(context); … … 58 56 m_ratio->setContext(context); 59 57 m_reduction->setContext(context); 60 m_attack->setContext(context);61 m_release->setContext(context);62 58 63 59 initialize(); … … 77 73 float knee = m_knee->value(); 78 74 float ratio = m_ratio->value(); 79 float attack = m_attack->value();80 float release = m_release->value();81 75 82 76 m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamThreshold, threshold); 83 77 m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamKnee, knee); 84 78 m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamRatio, ratio); 85 m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamAttack, attack);86 m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamRelease, release);87 79 88 80 m_dynamicsCompressor->process(input(0)->bus(), outputBus, framesToProcess); -
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.h
r110951 r110956 53 53 AudioParam* knee() { return m_knee.get(); } 54 54 AudioParam* ratio() { return m_ratio.get(); } 55 AudioParam* attack() { return m_attack.get(); }56 AudioParam* release() { return m_release.get(); }57 55 58 56 // Amount by which the compressor is currently compressing the signal in decibels. … … 70 68 RefPtr<AudioParam> m_ratio; 71 69 RefPtr<AudioParam> m_reduction; 72 RefPtr<AudioParam> m_attack;73 RefPtr<AudioParam> m_release;74 70 }; 75 71 -
trunk/Source/WebCore/webaudio/DynamicsCompressorNode.idl
r110951 r110956 32 32 readonly attribute AudioParam ratio; // unit-less 33 33 readonly attribute AudioParam reduction; // in Decibels 34 readonly attribute AudioParam attack; // in Seconds35 readonly attribute AudioParam release; // in Seconds36 34 }; 37 35 }
Note: See TracChangeset
for help on using the changeset viewer.