Changeset 110982 in webkit

Timestamp:

Mar 16, 2012 3:39:51 AM (12 years ago)

Author:

leo.yang@torchmobile.com.cn

Message:

[BlackBerry] Crash when going back from an xhtml document containing <img>
​https://bugs.webkit.org/show_bug.cgi?id=81297

Reviewed by Rob Buis.

This is manually reverting the offending internal commit which checked-in before upstreaming.

• WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::canCachePage):

Location:

trunk/Source/WebKit/blackberry

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/FrameLoaderClientBlackBerry.cpp (modified) (3 diffs)

trunk/Source/WebKit/blackberry/ChangeLog

@@ +1 @@
+2012-03-16  Leo Yang  <leo.yang@torchmobile.com.cn>
+
+        [BlackBerry] Crash when going back from an xhtml document containing <img>
+        https://bugs.webkit.org/show_bug.cgi?id=81297
+
+        Reviewed by Rob Buis.
+
+        This is manually reverting the offending internal commit which checked-in before upstreaming.
+
+        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+        (WebCore::FrameLoaderClientBlackBerry::canCachePage):
+
 2012-03-16  Genevieve Mak  <gmak@rim.com>
 

trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp

@@ -25 +25 @@
 #include "BackingStore_p.h"
 #include "Base64.h"
-#include "CachedImage.h"
 #include "Chrome.h"
 #include "ChromeClientBlackBerry.h"
@@ -35 +34 @@
 #include "HTMLFormElement.h"
 #include "HTMLHeadElement.h"
-#include "HTMLImageElement.h"
 #include "HTMLLinkElement.h"
 #include "HTMLMediaElement.h"
@@ -1208 +1206 @@
         return false;
 
-    // The multipart of "multipart/x-mixed-replace" only supports image, correct?
-    // FIXME: Do we have a better place to handle this case?
-    nodeList = m_frame->document()->getElementsByTagName(HTMLNames::imgTag.localName());
-    for (unsigned i = 0; i < nodeList.get()->length(); ++i) {
-        HTMLImageElement* node = static_cast<HTMLImageElement*>(nodeList.get()->item(i));
-        CachedImage* cachedimage = node ? node->cachedImage() : 0;
-        if (cachedimage && cachedimage->response().isMultipartPayload())
-            return false;
-    }
     return true;
 }