Changeset 111220 in webkit
- Timestamp:
- Mar 19, 2012 12:46:09 PM (12 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r111215 r111220 1 2012-03-19 Hao Zheng <zhenghao@chromium.org> 2 3 [chromium] DRT crashes at shutdown. 4 https://bugs.webkit.org/show_bug.cgi?id=81504 5 6 Reviewed by James Robinson. 7 8 WebCompositor must be destroyed after WebView is properly destroyed, 9 or some compositor objects like CCLayerTreeHost may not be destroyed. 10 However, it is really hard to make the destruction order correct 11 explicitly in ~TestShell. So move it out to DumpRenderTree. 12 13 * DumpRenderTree/chromium/DumpRenderTree.cpp: 14 (main): 15 * DumpRenderTree/chromium/TestShell.cpp: 16 (TestShell::~TestShell): 17 1 18 2012-03-19 Dirk Pranke <dpranke@chromium.org> 2 19 -
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
r107022 r111220 32 32 33 33 #include "TestShell.h" 34 #include "WebCompositor.h" 34 35 #include "webkit/support/webkit_support.h" 35 36 #include <v8/include/v8-testing.h> … … 287 288 } 288 289 290 // Shutdown WebCompositor after TestShell is destructed properly. 291 WebKit::WebCompositor::shutdown(); 292 289 293 return EXIT_SUCCESS; 290 294 } -
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
r110784 r111220 177 177 // Destroy the WebView before its WebViewHost. 178 178 m_drtDevToolsAgent->setWebView(0); 179 180 WebCompositor::shutdown();181 179 } 182 180
Note: See TracChangeset
for help on using the changeset viewer.