Changeset 111545 in webkit


Ignore:
Timestamp:
Mar 21, 2012 7:51:12 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Convert some fast/regions pixel tests to reftests
​https://bugs.webkit.org/show_bug.cgi?id=80602

Patch by hermwong <​herm.wong@gmail.com> on 2012-03-21
Reviewed by Dirk Schulze.

  • convert CSS regions tests from pixel tests to reftests.
  • removed unnecessary image files that were used for pixel tests.
  • added *.expected.html as the control for the reftests - these will render the position of objects without using CSS regions
  • removed the "no red should be visible..." text from the positioned-objects-inline-static-in-rtl-regions because there was no red in the test file and the statement was irrelevant to the test.
  • removed text from the positioned-objects-inline-static-spanning-regions.html test because it had nothing to do with the test. We based this on the visuals of the test and the fact that the test description made no mention of the text at all
  • fast/regions/positioned-objects-clipped-spanning-regions-expected.html: Added.
  • fast/regions/positioned-objects-clipped-spanning-regions.html:
  • fast/regions/positioned-objects-in-regions-expected.html: Added.
  • fast/regions/positioned-objects-in-rtl-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
  • fast/regions/positioned-objects-inline-static-in-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-regions.html.
  • fast/regions/positioned-objects-inline-static-in-regions.html:
  • fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
  • fast/regions/positioned-objects-inline-static-in-rtl-regions.html: no red should be visible because there was no red in the test file and the statement was irrelevant to the test.
  • fast/regions/positioned-objects-inline-static-spanning-regions-expected.html: Added.
  • fast/regions/positioned-objects-inline-static-spanning-regions.html:
  • fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
  • fast/regions/positioned-objects-spanning-regions-expected.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-in-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-in-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-in-rtl-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-spanning-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-spanning-regions-expected.txt: Removed.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
  • platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-spanning-regions-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
4 added
35 deleted
6 edited
4 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r111544 r111545  
     12012-03-21  hermwong  <herm.wong@gmail.com>
     2
     3        Convert some fast/regions pixel tests to reftests
     4        https://bugs.webkit.org/show_bug.cgi?id=80602
     5
     6        Reviewed by Dirk Schulze.
     7
     8        - convert CSS regions tests from pixel tests to reftests.
     9        - removed unnecessary image files that were used for pixel tests.
     10        - added *.expected.html as the control for the reftests - these will render the position of objects without using CSS regions
     11        - removed the "no red should be visible..." text from the positioned-objects-inline-static-in-rtl-regions because there was no red in the test file and the statement was irrelevant to the test.   
     12        - removed text from the positioned-objects-inline-static-spanning-regions.html test because it had nothing to do with the test. We based this on the visuals of the test and the fact that the test description made no mention of the text at all     
     13
     14        * fast/regions/positioned-objects-clipped-spanning-regions-expected.html: Added.
     15        * fast/regions/positioned-objects-clipped-spanning-regions.html:
     16        * fast/regions/positioned-objects-in-regions-expected.html: Added.
     17        * fast/regions/positioned-objects-in-rtl-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
     18        * fast/regions/positioned-objects-inline-static-in-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-regions.html.
     19        * fast/regions/positioned-objects-inline-static-in-regions.html:
     20        * fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
     21        * fast/regions/positioned-objects-inline-static-in-rtl-regions.html:    no red should be visible because there was no red in the test file and the statement was irrelevant to the test.
     22        * fast/regions/positioned-objects-inline-static-spanning-regions-expected.html: Added.
     23        * fast/regions/positioned-objects-inline-static-spanning-regions.html:
     24        * fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
     25        * fast/regions/positioned-objects-spanning-regions-expected.html: Added.
     26        * platform/chromium/test_expectations.txt:
     27        * platform/efl/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Removed.
     28        * platform/efl/fast/regions/positioned-objects-in-regions-expected.png: Removed.
     29        * platform/efl/fast/regions/positioned-objects-in-regions-expected.txt: Removed.
     30        * platform/efl/fast/regions/positioned-objects-in-rtl-regions-expected.png: Removed.
     31        * platform/efl/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Removed.
     32        * platform/efl/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Removed.
     33        * platform/efl/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Removed.
     34        * platform/efl/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Removed.
     35        * platform/efl/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Removed.
     36        * platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Removed.
     37        * platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Removed.
     38        * platform/efl/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Removed.
     39        * platform/efl/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Removed.
     40        * platform/efl/fast/regions/positioned-objects-spanning-regions-expected.png: Removed.
     41        * platform/efl/fast/regions/positioned-objects-spanning-regions-expected.txt: Removed.
     42        * platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
     43        * platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
     44        * platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Removed.
     45        * platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt: Removed.
     46        * platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Removed.
     47        * platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Removed.
     48        * platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Removed.
     49        * platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Removed.
     50        * platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Removed.
     51        * platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Removed.
     52        * platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Removed.
     53        * platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Removed.
     54        * platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Removed.
     55        * platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Removed.
     56        * platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
     57        * platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
     58        * platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Removed.
     59        * platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Removed.
     60        * platform/mac/fast/regions/positioned-objects-spanning-regions-expected.png: Removed.
     61        * platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt: Removed.
     62
    1632012-03-21  Keishi Hattori  <keishi@webkit.org>
    264

  • trunk/LayoutTests/fast/regions/positioned-objects-clipped-spanning-regions.html

    • Property svn:executable set to *

  • trunk/LayoutTests/fast/regions/positioned-objects-in-rtl-regions-expected.html

    • Property svn:executable set to *
    r111544 r111545  
    44 <style>
    55    #content {
    6        -webkit-flow-into: flow1;
     6       
     7        text-align: justify;
     8        padding: 5px;
    79    }
    810   
    9     #first-box {
    10         margin:10%;
    11         text-align:center;
     11    #green-box {
     12                background-color: green;
     13                width: 50%;
     14                height: 100%;
    1215    }
    1316   
    14     #second-box {
    15         position:absolute;
    16         top:0;
    17         bottom:0;
    18         width:100px;
    19         background-color:green
    20     }
    2117   
    2218    #region1, #region2, #region3 {
    2319        border: 1px solid black;
    24         -webkit-flow-from: flow1;
     20       
    2521    }
    2622
    … …  
    4339<body>
    4440<p style="direction:ltr">The green positioned object should only be as tall as the first region it
    45 is contained in. It should fill the left half of the first region, and no red
    46 should be visible.</p>
     41is contained in. It should fill the right half of the first region.</p>
    4742
    48 <div id="content">
    49     <div id="first-box">
    50         <span id="second-box">
    51         </span>
    52         </div>
     43
     44
     45
     46
     47    <div id="region1">
     48        <div id="green-box"></div>
    5349    </div>
    54 </div>
    55 
    56 <div id="container">
    57     <div id="region1"></div>
    5850    <div id="region2"></div>
    5951    <div id="region3"></div>
    60 </div>
     52

  • trunk/LayoutTests/fast/regions/positioned-objects-inline-static-in-regions-expected.html

    • Property svn:executable set to *
    r111544 r111545  
    22
    33 <style>
    4     #content {
    5        -webkit-flow-into: flow1;
     4    #first-box {
     5        height: 100%;
     6        width: 50%;
     7        background-color: green;
     8        float: right;
    69    }
    7    
    8     #first-box {
    9         margin:10%;
    10         text-align:center;
    11     }
    12    
    13     #second-box {
    14         position:absolute;
    15         top:0;
    16         bottom:0;
    17         width:100px;
    18         background-color:green
    19     }
     10
    2011   
    2112    #region1, #region2, #region3 {
    2213        border: 1px solid black;
    23         -webkit-flow-from: flow1;
    2414    }
    2515
    … …  
    2717        width: 200px;
    2818        height: 150px;
     19       
    2920    }
    3021   
    … …  
    4536should be visible.</p>
    4637
    47 <div id="content">
    48     <div id="first-box">
    49         <span id="second-box">
    50         </span>
     38
     39
     40
     41    <div id="region1">
     42        <div id="first-box">
    5143        </div>
    5244    </div>
    53 </div>
    54 
    55 <div id="container">
    56     <div id="region1"></div>
    5745    <div id="region2"></div>
    5846    <div id="region3"></div>
    59 </div>
     47

  • trunk/LayoutTests/fast/regions/positioned-objects-inline-static-in-regions.html

    • Property svn:executable set to *
    r97701 r111545  
    4949        <span id="second-box">
    5050        </span>
    51         </div>
    5251    </div>
    5352</div>

  • trunk/LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.html

    • Property svn:executable set to *
    r111544 r111545  
    22<html style="direction:rtl">
    33<head>
    4  <style>
    5     #content {
    6        -webkit-flow-into: flow1;
     4 <style>   
     5    #green-box {
     6
     7        text-align:center;
     8                background-color:green;
     9                height:100%;
     10                float: left;
     11                width:50%;
    712    }
    813   
    9     #first-box {
    10         margin:10%;
    11         text-align:center;
    12     }
    13    
    14     #second-box {
    15         position:absolute;
    16         top:0;
    17         bottom:0;
    18         width:100px;
    19         background-color:green
    20     }
     14
    2115   
    2216    #region1, #region2, #region3 {
    2317        border: 1px solid black;
    24         -webkit-flow-from: flow1;
     18       
    2519    }
    2620
    … …  
    4337<body>
    4438<p style="direction:ltr">The green positioned object should only be as tall as the first region it
    45 is contained in. It should fill the left half of the first region, and no red
    46 should be visible.</p>
     39is contained in. It should fill the left half of the first region.</p>
    4740
    48 <div id="content">
    49     <div id="first-box">
    50         <span id="second-box">
    51         </span>
    52         </div>
    53     </div>
     41
     42
     43
     44
     45<div id="region1">
     46        <div id="green-box"></div>
    5447</div>
     48<div id="region2"></div>
     49<div id="region3"></div>
    5550
    56 <div id="container">
    57     <div id="region1"></div>
    58     <div id="region2"></div>
    59     <div id="region3"></div>
    60 </div>

  • trunk/LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html

    • Property svn:executable set to *
    r97701 r111545  
    1717        bottom:0;
    1818        width:100px;
    19         background-color:green
     19        background-color:green;
    2020    }
    2121   
    … …  
    4343<body>
    4444<p style="direction:ltr">The green positioned object should only be as tall as the first region it
    45 is contained in. It should fill the left half of the first region, and no red
    46 should be visible.</p>
     45is contained in. It should fill the left half of the first region.</p>
    4746
    4847<div id="content">

  • trunk/LayoutTests/fast/regions/positioned-objects-inline-static-spanning-regions.html

    • Property svn:executable set to *
    r97701 r111545  
    4848<div id="content">
    4949    <div id="first-box">
    50         &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<span id="second-box">
    51             Some text.<br>
    52              Some text.<br>
    53               Some text.<br>
    54                Some text.<br>
    55                 Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br>      </span>
     50        &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<span id="second-box"></span>
    5651    </div>
    5752</div>

  • trunk/LayoutTests/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.html

    • Property svn:executable set to *
    r111544 r111545  
    33<head>
    44 <style>
    5     #content {
    6        -webkit-flow-into: flow1;
     5    #first-box {
     6        height: 100%;
     7        width: 50%;
     8        background-color: green;
     9        float: left;
    710    }
    8    
    9     #first-box {
    10         margin:10%;
    11         text-align:center;
    12     }
    13    
    14     #second-box {
    15         position:absolute;
    16         top:0;
    17         bottom:0;
    18         width:100px;
    19         background-color:green
    20     }
    21    
     11
    2212    #region1, #region2, #region3 {
    2313        border: 1px solid black;
    24         -webkit-flow-from: flow1;
    2514    }
    2615
    … …  
    4332<body>
    4433<p style="direction:ltr">The green positioned object should only be as tall as the first region it
    45 is contained in. It should fill the left half of the first region, and no red
    46 should be visible.</p>
     34is contained in. It should fill the left half of the first region.</p>
    4735
    48 <div id="content">
    49     <div id="first-box">
    50         <span id="second-box">
    51         </span>
     36
     37
     38    <div id="region1">
     39        <div id="first-box">
    5240        </div>
    5341    </div>
    54 </div>
    55 
    56 <div id="container">
    57     <div id="region1"></div>
    5842    <div id="region2"></div>
    5943    <div id="region3"></div>
    60 </div>

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r111541 r111545  
    33103310BUGWK74137 : fast/regions/percentage-margins-variable-width-regions.html = PASS FAIL MISSING
    33113311BUGWK74137 : fast/regions/position-writing-modes-in-variable-width-regions.html = PASS FAIL MISSING
    3312 BUGWK74137 : fast/regions/positioned-objects-clipped-spanning-regions.html = PASS FAIL MISSING
    3313 BUGWK74137 : fast/regions/positioned-objects-in-regions.html = PASS FAIL MISSING
    3314 BUGWK74137 : fast/regions/positioned-objects-in-rtl-regions.html = PASS FAIL MISSING
    3315 BUGWK74137 : fast/regions/positioned-objects-inline-static-in-regions.html = PASS FAIL MISSING
    3316 BUGWK74137 : fast/regions/positioned-objects-inline-static-in-rtl-regions.html = PASS FAIL MISSING
    33173312BUGWK74137 : fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html = PASS FAIL MISSING
    3318 BUGWK74137 : fast/regions/positioned-objects-inline-static-spanning-regions.html = PASS FAIL MISSING
    3319 BUGWK74137 : fast/regions/positioned-objects-perpendicular-flows-in-regions.html = PASS FAIL MISSING
    3320 BUGWK74137 : fast/regions/positioned-objects-spanning-regions.html = PASS FAIL MISSING
    33213313BUGWK74137 : fast/regions/region-overflow-auto-overflow-hidden.html = PASS FAIL MISSING
    33223314BUGWK74137 : fast/regions/region-overflow-auto-overflow-visible.html = PASS FAIL MISSING
Note: See TracChangeset for help on using the changeset viewer.