Changeset 111613 in webkit

Timestamp:

Mar 21, 2012 3:42:25 PM (12 years ago)

Author:

leviw@chromium.org

Message:

Correct LayoutUnit usage in VisiblePosition.cpp
​https://bugs.webkit.org/show_bug.cgi?id=81775

Reviewed by Eric Seidel.

Correcting a mismatch between the .h and .cpp for the definition of localCaretRect,
and properly using LayoutUnits for local coordinates.

No new tests. No change in behavior.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::localCaretRect): Switching to return a LayoutRect, as in the
header. Local coordinates are in LayoutUnits.
(WebCore::VisiblePosition::absoluteCaretBounds): Using LayoutRect for the localCaretRect.
(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation): Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/VisiblePosition.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-21  Levi Weintraub  <leviw@chromium.org>
+
+        Correct LayoutUnit usage in VisiblePosition.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=81775
+
+        Reviewed by Eric Seidel.
+
+        Correcting a mismatch between the .h and .cpp for the definition of localCaretRect,
+        and properly using LayoutUnits for local coordinates.
+
+        No new tests. No change in behavior.
+
+        * editing/VisiblePosition.cpp:
+        (WebCore::VisiblePosition::localCaretRect): Switching to return a LayoutRect, as in the
+        header. Local coordinates are in LayoutUnits.
+        (WebCore::VisiblePosition::absoluteCaretBounds): Using LayoutRect for the localCaretRect.
+        (WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation): Ditto.
+
 2012-03-21  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/editing/VisiblePosition.cpp

@@ -596 +596 @@
 }
 
-IntRect VisiblePosition::localCaretRect(RenderObject*& renderer) const
+LayoutRect VisiblePosition::localCaretRect(RenderObject*& renderer) const
 {
     if (m_deepPosition.isNull()) {
@@ -606 +606 @@
     renderer = node->renderer();
     if (!renderer)
-        return IntRect();
+        return LayoutRect();
 
     InlineBox* inlineBox;
@@ -621 +621 @@
 {
     RenderObject* renderer;
-    IntRect localRect = localCaretRect(renderer);
+    LayoutRect localRect = localCaretRect(renderer);
     if (localRect.isEmpty() || !renderer)
         return IntRect();
@@ -631 +631 @@
 {
     RenderObject* renderer;
-    IntRect localRect = localCaretRect(renderer);
+    LayoutRect localRect = localCaretRect(renderer);
     if (localRect.isEmpty() || !renderer)
         return 0;