Changeset 111835 in webkit


Ignore:
Timestamp:
Mar 23, 2012 12:25:25 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[EFL][DRT] Implement LayoutTestController's methods related with editing.
​https://bugs.webkit.org/show_bug.cgi?id=80136

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com> on 2012-03-23
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

Implements DumpRenderTreeSupportEfl's and EditorClientEfl's methods related with editing.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled): New function.
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled): New function.

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::setSmartInsertDeleteEnabled): New function.
(WebCore):
(WebCore::EditorClientEfl::smartInsertDeleteEnabled): Add implementation.
(WebCore::EditorClientEfl::setSelectTrailingWhitespaceEnabled): New function.
(WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled): Add implementation.
(WebCore::EditorClientEfl::EditorClientEfl):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Tools:

Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
setSelectTrailingWhitespaceEnabled.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setSmartInsertDeleteEnabled):
(LayoutTestController::setSelectTrailingWhitespaceEnabled):

LayoutTests:

Enables tests connected with setSelectTrailingWhitespaceEnabled and setSmartInsertDeleteEnabled.
Tests related with spelling can not be enabled in this patch because WebKit-Efl doesn't
support spell checking (missing TextCheckerClient implementation).

  • platform/efl/Skipped:
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r111833 r111835  
     12012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
     2
     3        [EFL][DRT] Implement LayoutTestController's methods related with editing.
     4        https://bugs.webkit.org/show_bug.cgi?id=80136
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Enables tests connected with setSelectTrailingWhitespaceEnabled and setSmartInsertDeleteEnabled.
     9        Tests related with spelling can not be enabled in this patch because WebKit-Efl doesn't
     10        support spell checking (missing TextCheckerClient implementation).
     11
     12        * platform/efl/Skipped:
     13
    1142012-03-22  Dan Bernstein  <mitz@apple.com>
    215

  • trunk/LayoutTests/platform/efl/Skipped

    r111756 r111835  
    6262svg/zoom/page/zoom-zoom-coords.xhtml
    6363
    64 # EFL's EventSender needs to emit double clicks
     64# EFL's EventSender needs to emit double clicks (e.g. to select text)
     65editing/selection/doubleclick-inline-first-last-contenteditable.html
    6566fast/events/dblclick-addEventListener.html
    6667fast/forms/password-doubleclick-selection.html
    … …  
    442443plugins/netscape-plugin-setwindow-size-2.html
    443444
    444 # EFL's LayoutTestController does not implement setSmartInsertDeleteEnabled
    445 editing/deleting/smart-editing-disabled.html
    446 editing/selection/doubleclick-beside-cr-span.html
    447 editing/selection/doubleclick-whitespace-crash.html
    448 editing/selection/doubleclick-whitespace-img-crash.html
    449 editing/selection/doubleclick-whitespace.html
    450 
    451445# EFL's LayoutTestController does not implement setJavaScriptCanAccessClipboard
    452446editing/execCommand/clipboard-access.html
    … …  
    473467# EFL's LayoutTestController does not implement setJavaScriptProfilingEnabled
    474468fast/profiler
    475 
    476 # EFL's LayoutTestController does not implement setSelectTrailingWhitespaceEnabled
    477 editing/selection/doubleclick-beside-cr-span.html
    478 editing/selection/doubleclick-inline-first-last-contenteditable.html
    479 editing/selection/doubleclick-whitespace-crash.html
    480 editing/selection/doubleclick-whitespace-img-crash.html
    481 editing/selection/doubleclick-whitespace.html
    482469
    483470# EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
    … …  
    700687fast/harness/show-modal-dialog.html
    701688
    702 # EFL's LayoutTestController does not implement hasSpellingMarker
     689# Missing TextCheckerClient implementation (Efl's port does not support spell checking, Gtk port uses Enchant library https://bugs.webkit.org/show_bug.cgi?id=61787)
    703690editing/spelling/design-mode-spellcheck-off.html
    704691editing/spelling/spellcheck-attribute.html

  • trunk/Source/WebKit/efl/ChangeLog

    r111756 r111835  
     12012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
     2
     3        [EFL][DRT] Implement LayoutTestController's methods related with editing.
     4        https://bugs.webkit.org/show_bug.cgi?id=80136
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Implements DumpRenderTreeSupportEfl's and EditorClientEfl's methods related with editing.
     9
     10        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
     11        (DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled): New function.
     12        (DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled): New function.
     13        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
     14        * WebCoreSupport/EditorClientEfl.cpp:
     15        (WebCore::EditorClientEfl::setSmartInsertDeleteEnabled): New function.
     16        (WebCore):
     17        (WebCore::EditorClientEfl::smartInsertDeleteEnabled): Add implementation.
     18        (WebCore::EditorClientEfl::setSelectTrailingWhitespaceEnabled): New function.
     19        (WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled): Add implementation.
     20        (WebCore::EditorClientEfl::EditorClientEfl):
     21        * WebCoreSupport/EditorClientEfl.h:
     22        (EditorClientEfl):
     23
    1242012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
    225

  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp

    r111756 r111835  
    2727#include <AnimationController.h>
    2828#include <DocumentLoader.h>
     29#include <EditorClientEfl.h>
    2930#include <Eina.h>
    3031#include <Evas.h>
    … …  
    323324}
    324325
     326void DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled)
     327{
     328    WebCore::Page* page = EWKPrivate::corePage(ewkView);
     329    if (!page)
     330        return;
     331
     332    WebCore::EditorClientEfl* editorClient = static_cast<WebCore::EditorClientEfl*>(page->editorClient());
     333    if (!editorClient)
     334        return;
     335
     336    editorClient->setSmartInsertDeleteEnabled(enabled);
     337}
     338
     339void DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled)
     340{
     341    WebCore::Page* page = EWKPrivate::corePage(ewkView);
     342    if (!page)
     343        return;
     344
     345    WebCore::EditorClientEfl* editorClient = static_cast<WebCore::EditorClientEfl*>(page->editorClient());
     346    if (!editorClient)
     347        return;
     348
     349    editorClient->setSelectTrailingWhitespaceEnabled(enabled);
     350}
     351
    325352void DumpRenderTreeSupportEfl::garbageCollectorCollect()
    326353{

  • trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h

    r111756 r111835  
    6767
    6868    static bool findString(const Evas_Object* ewkView, const char* text, WebCore::FindOptions);
     69    static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
     70    static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
    6971
    7072    static void garbageCollectorCollect();

  • trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp

    r108462 r111835  
    2424#include "EditorClientEfl.h"
    2525
     26#include "DumpRenderTreeSupportEfl.h"
    2627#include "Editor.h"
    2728#include "EventNames.h"
    … …  
    230231}
    231232
     233void EditorClientEfl::setSmartInsertDeleteEnabled(bool enabled)
     234{
     235    m_smartInsertDeleteEnabled = enabled;
     236    if (enabled)
     237        setSelectTrailingWhitespaceEnabled(false);
     238}
     239
    232240bool EditorClientEfl::smartInsertDeleteEnabled()
    233241{
    234     notImplemented();
    235     return false;
     242    return m_smartInsertDeleteEnabled;
     243}
     244
     245void EditorClientEfl::setSelectTrailingWhitespaceEnabled(bool enabled)
     246{
     247    m_selectTrailingWhitespaceEnabled = enabled;
     248    if (enabled)
     249        setSmartInsertDeleteEnabled(false);
    236250}
    237251
    238252bool EditorClientEfl::isSelectTrailingWhitespaceEnabled()
    239253{
    240     notImplemented();
    241     return false;
     254    return m_selectTrailingWhitespaceEnabled;
    242255}
    243256
    … …  
    438451    : m_isInRedo(false)
    439452    , m_view(view)
     453    , m_selectTrailingWhitespaceEnabled(false)
     454    , m_smartInsertDeleteEnabled(false)
    440455{
    441456    notImplemented();

  • trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h

    r108772 r111835  
    6161    virtual bool shouldShowDeleteInterface(HTMLElement*);
    6262    virtual bool smartInsertDeleteEnabled();
     63    void setSmartInsertDeleteEnabled(bool);
    6364    virtual bool isSelectTrailingWhitespaceEnabled();
     65    void setSelectTrailingWhitespaceEnabled(bool);
    6466    virtual bool isContinuousSpellCheckingEnabled();
    6567    virtual void toggleContinuousSpellChecking();
    … …  
    126128private:
    127129    Evas_Object *m_view;
     130    bool m_selectTrailingWhitespaceEnabled;
     131    bool m_smartInsertDeleteEnabled;
    128132};
    129133}

  • trunk/Tools/ChangeLog

    r111824 r111835  
     12012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
     2
     3        [EFL][DRT] Implement LayoutTestController's methods related with editing.
     4        https://bugs.webkit.org/show_bug.cgi?id=80136
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
     9        setSelectTrailingWhitespaceEnabled.
     10
     11        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
     12        (LayoutTestController::setSmartInsertDeleteEnabled):
     13        (LayoutTestController::setSelectTrailingWhitespaceEnabled):
     14
    1152012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    216

  • trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

    r111824 r111835  
    287287}
    288288
    289 void LayoutTestController::setSmartInsertDeleteEnabled(bool)
    290 {
    291     notImplemented();
     289void LayoutTestController::setSmartInsertDeleteEnabled(bool flag)
     290{
     291    DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled(browser->mainView(), flag);
    292292}
    293293
    … …  
    447447}
    448448
    449 void LayoutTestController::setSelectTrailingWhitespaceEnabled(bool)
    450 {
    451     notImplemented();
     449void LayoutTestController::setSelectTrailingWhitespaceEnabled(bool flag)
     450{
     451    DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled(browser->mainView(), flag);
    452452}
    453453
Note: See TracChangeset for help on using the changeset viewer.