Changeset 112020 in webkit

Timestamp:

Mar 24, 2012 8:59:40 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Quick fix for rendering controls regression.
​https://bugs.webkit.org/show_bug.cgi?id=82125

Patch by Victor Carbune <​vcarbune@adobe.com> on 2012-03-24
Reviewed by Eric Carlson.

Only temporary fix. Tests to cover the problem should be added

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeOpaque): The display:none
property should be toggled only by the media element now.
(WebCore::MediaControlPanelElement::makeTransparent): The timer
that toggles the dispalay:none shouldn't be used now.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/shadow/MediaControlElements.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-24  Victor Carbune  <vcarbune@adobe.com>
+
+        Quick fix for rendering controls regression.
+        https://bugs.webkit.org/show_bug.cgi?id=82125
+
+        Reviewed by Eric Carlson.
+
+        Only temporary fix. Tests to cover the problem should be added
+
+        * html/shadow/MediaControlElements.cpp:
+        (WebCore::MediaControlPanelElement::makeOpaque): The display:none
+        property should be toggled only by the media element now.
+        (WebCore::MediaControlPanelElement::makeTransparent): The timer
+        that toggles the dispalay:none shouldn't be used now.
+
 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/Source/WebCore/html/shadow/MediaControlElements.cpp

@@ -243 +243 @@
     m_opaque = true;
 
-    show();
+    // FIXME(BUG 79347): The display:none property should be toggled below only
+    // when display logic is introduced.
+    // show();
 }
 
@@ -257 +259 @@
     m_opaque = false;
 
-    startTimer();
+    // FIXME(BUG 79347): The display:none property should be toggled below
+    // (through the timer start) when display logic is introduced.
+    // startTimer();
 }