Changeset 112066 in webkit

Timestamp:

Mar 26, 2012 2:07:43 AM (12 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: replace indexOf('a text') === 0 with RegExp because it is much faster.
​https://bugs.webkit.org/show_bug.cgi?id=82175

We were using aString.indexOf("Window") but it is not effective from performance point of view.
I'm replaced it with RegExp.

Reviewed by Yury Semikhatsky.

• inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get isWindow):
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/HeapSnapshot.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-26  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: replace indexOf('a text') === 0 with RegExp because it is much faster.
+        https://bugs.webkit.org/show_bug.cgi?id=82175
+
+        We were using aString.indexOf("Window") but it is not effective from performance point of view.
+        I'm replaced it with RegExp.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/HeapSnapshot.js:
+        (WebInspector.HeapSnapshotNode.prototype.get isWindow):
+        (WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):
+
 2012-03-26  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js

@@ -635 +635 @@
     get isWindow()
     {
-        return this.name.indexOf("Window") === 0;
+        const windowRE = /^Window/;
+        return windowRE.test(this.name);
     },
 
@@ -645 +646 @@
     get isDetachedDOMTree()
     {
-        return this.className.indexOf("Detached DOM tree") === 0;
+        const detachedDOMTreeRE = /^Detached DOM tree/;
+        return detachedDOMTreeRE.test(this.className);
     },