Changeset 112084 in webkit

Timestamp:

Mar 26, 2012 6:23:22 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] Taps are sometimes not highlighted.
​https://bugs.webkit.org/show_bug.cgi?id=82188

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

Highlight any focusable parent element, or if none is found at least
the element returned by bestClickableNodeForTouchPoint.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-03-26  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
+
+        [Qt] Taps are sometimes not highlighted.
+        https://bugs.webkit.org/show_bug.cgi?id=82188
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Highlight any focusable parent element, or if none is found at least
+        the element returned by bestClickableNodeForTouchPoint.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::highlightPotentialActivation):
+
 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -1462 +1462 @@
         activationNode = result.innerNode();
 #endif
-        if (activationNode && !activationNode->isFocusable())
-            activationNode = activationNode->enclosingLinkEventParentOrSelf();
+        if (activationNode && !activationNode->isFocusable()) {
+            for (Node* node = activationNode; node; node = node->parentOrHostNode()) {
+                if (node->isFocusable()) {
+                    activationNode = node;
+                    break;
+                }
+            }
+        }
     }