Changeset 112095 in webkit

Timestamp:

Mar 26, 2012 7:49:18 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] Disable focus ring in the mobile theme.
​https://bugs.webkit.org/show_bug.cgi?id=81934

For mobile devices intended to be used only through
touch, the focus rings makes little sense and feels
awkward.

Patch by Pierre Rossi <​pierre.rossi@nokia.com> on 2012-03-26
Reviewed by Kenneth Rohde Christiansen.

No new tests. This is merely a cosmetic touch.

• platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::platformFocusRingColor):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/RenderThemeQtMobile.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-26  Pierre Rossi  <pierre.rossi@nokia.com>
+
+        [Qt] Disable focus ring in the mobile theme.
+        https://bugs.webkit.org/show_bug.cgi?id=81934
+
+        For mobile devices intended to be used only through
+        touch, the focus rings makes little sense and feels
+        awkward.
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        No new tests. This is merely a cosmetic touch.
+
+        * platform/qt/RenderThemeQtMobile.h:
+        (RenderThemeQtMobile):
+        (WebCore::RenderThemeQtMobile::platformFocusRingColor):
+
 2012-03-26  Charles Wei  <charles.wei@torchmobile.com.cn>
 

trunk/Source/WebCore/platform/qt/RenderThemeQtMobile.h

@@ -53 +53 @@
 
     virtual bool delegatesMenuListRendering() const { return true; }
+
+    // drawFocusRing() will return early if the color is invalid.
+    virtual Color platformFocusRingColor() const { return Color(); }
 
 protected: