Changeset 112148 in webkit

Timestamp:

Mar 26, 2012 2:43:55 PM (12 years ago)

Author:

andersca@apple.com

Message:

Find in page overlay and bouncy are not always positioned correctly
​https://bugs.webkit.org/show_bug.cgi?id=82247
<rdar://problem/10866139>

Reviewed by Sam Weinig.

In WebCore, a lot of code depends on scroll position updates to happen synchronously, so
update the frame view scroll position before asking the scrolling thread to scroll.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-26  Anders Carlsson  <andersca@apple.com>
+
+        Find in page overlay and bouncy are not always positioned correctly
+        https://bugs.webkit.org/show_bug.cgi?id=82247
+        <rdar://problem/10866139>
+
+        Reviewed by Sam Weinig.
+
+        In WebCore, a lot of code depends on scroll position updates to happen synchronously, so
+        update the frame view scroll position before asking the scrolling thread to scroll.
+
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
+
 2012-03-26  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -229 +229 @@
 
 #if ENABLE(THREADED_SCROLLING)
+    // Update the main frame scroll position locally before asking the scrolling thread to scroll,
+    // since FrameView expects scroll position updates to happen synchronously.
+    updateMainFrameScrollPosition(scrollPosition);
+
     ScrollingThread::dispatch(bind(&ScrollingTree::setMainFrameScrollPosition, m_scrollingTree.get(), scrollPosition));
     return true;