Changeset 112235 in webkit


Ignore:
Timestamp:
Mar 27, 2012 2:48:21 AM (12 years ago)
Author:
nduca@chromium.org
Message:

[chromium] Fix crash with fling with tracing enabled
https://bugs.webkit.org/show_bug.cgi?id=82306

The TRACE_EVENT_START instrumentation was deferencing a PassOwnPtr
after it had been passed into another OwnPtr. This caused frequent
crashes when tracing was enabled.

Reviewed by Adam Barth.

  • platform/ActivePlatformGestureAnimation.cpp:

(WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):

  • platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:

(WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r112234 r112235  
     12012-03-27  Nat Duca  <nduca@chromium.org>
     2
     3        [chromium] Fix crash with fling with tracing enabled
     4        https://bugs.webkit.org/show_bug.cgi?id=82306
     5
     6        The TRACE_EVENT_START instrumentation was deferencing a PassOwnPtr
     7        after it had been passed into another OwnPtr. This caused frequent
     8        crashes when tracing was enabled.
     9
     10        Reviewed by Adam Barth.
     11
     12        * platform/ActivePlatformGestureAnimation.cpp:
     13        (WebCore::ActivePlatformGestureAnimation::ActivePlatformGestureAnimation):
     14        * platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:
     15        (WebCore::CCActiveGestureAnimation::CCActiveGestureAnimation):
     16
    1172012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
    218
  • trunk/Source/WebCore/platform/ActivePlatformGestureAnimation.cpp

    r112024 r112235  
    5656{
    5757#if PLATFORM(CHROMIUM)
    58     TRACE_EVENT_START1("input", "GestureAnimation", this, "curve", curve->debugName());
     58    TRACE_EVENT_START1("input", "GestureAnimation", this, "curve", m_curve->debugName());
    5959#endif
    6060}
  • trunk/Source/WebCore/platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp

    r112024 r112235  
    4343    , m_gestureCurveTarget(target)
    4444{
    45     TRACE_EVENT_START1("input", "GestureAnimation", this, "curve", curve->debugName());
     45    TRACE_EVENT_START1("input", "GestureAnimation", this, "curve", m_gestureCurve->debugName());
    4646}
    4747
Note: See TracChangeset for help on using the changeset viewer.