Changeset 112251 in webkit

Timestamp:

Mar 27, 2012 4:40:29 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Editable TextViewer should show cursor when it is focused.
​https://bugs.webkit.org/show_bug.cgi?id=82320

Reviewed by Pavel Feldman.

TextViewer now focuses editable inner container unless read-only flag is set.

• inspector/front-end/TextViewer.js:

(WebInspector.TextViewer.prototype.focus):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._handleElementFocus):
(WebInspector.TextEditorMainPanel.prototype.focus):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextViewer.js (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Editable TextViewer should show cursor when it is focused.
+        https://bugs.webkit.org/show_bug.cgi?id=82320
+
+        Reviewed by Pavel Feldman.
+
+        TextViewer now focuses editable inner container unless read-only flag is set.
+
+        * inspector/front-end/TextViewer.js:
+        (WebInspector.TextViewer.prototype.focus):
+        (WebInspector.TextEditorMainPanel):
+        (WebInspector.TextEditorMainPanel.prototype._handleElementFocus):
+        (WebInspector.TextEditorMainPanel.prototype.focus):
+
 2012-03-26  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TextViewer.js

@@ -101 +101 @@
     focus: function()
     {
-        this._mainPanel.element.focus();
+        this._mainPanel.focus();
     },
 
@@ -905 +905 @@
 
     this.element.addEventListener("scroll", this._scroll.bind(this), false);
+    this.element.addEventListener("focus", this._handleElementFocus.bind(this), false);
 
     // In WebKit the DOMNodeRemoved event is fired AFTER the node is removed, thus it should be
@@ -948 +949 @@
     {
         return this._readOnly;
+    },
+
+    _handleElementFocus: function()
+    {
+        if (!this._readOnly)
+            this._container.focus();
+    },
+
+    focus: function()
+    {
+        if (this._readOnly)
+            this.element.focus();
+        else
+            this._container.focus();
     },