Changeset 112256 in webkit

Timestamp:

Mar 27, 2012 5:22:42 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Tree outline should not start search on key press if it is being edited.
​https://bugs.webkit.org/show_bug.cgi?id=82327

Reviewed by Pavel Feldman.

This is needed for snippet renaming support.

• inspector/front-end/treeoutline.js:

(TreeOutline):
(TreeOutline.prototype._treeKeyPress):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/treeoutline.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Tree outline should not start search on key press if it is being edited.
+        https://bugs.webkit.org/show_bug.cgi?id=82327
+
+        Reviewed by Pavel Feldman.
+
+        This is needed for snippet renaming support.
+
+        * inspector/front-end/treeoutline.js:
+        (TreeOutline):
+        (TreeOutline.prototype._treeKeyPress):
+
 2012-03-27  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/treeoutline.js

@@ -39 +39 @@
     this.selectedTreeElement = null;
     this._childrenListNode = listNode;
+    this.childrenListElement = this._childrenListNode;
     this._childrenListNode.removeChildren();
     this.expandTreeElementsWhenArrowing = false;
@@ -336 +337 @@
 TreeOutline.prototype._treeKeyPress = function(event)
 {
-    if (!this.searchable)
+    if (!this.searchable || WebInspector.isBeingEdited(this._childrenListNode))
         return;