Changeset 112257 in webkit
- Timestamp:
- Mar 27, 2012 5:32:06 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r112256 r112257 1 2012-03-27 Vsevolod Vlasov <vsevik@chromium.org> 2 3 Web Inspector: startEditing should remove tabIndex attribute from the element if it was not set before. 4 https://bugs.webkit.org/show_bug.cgi?id=82322 5 6 Reviewed by Pavel Feldman. 7 8 This patch removes tabIndex attribute from the element after editing if it was not present before. 9 Otherwise tabIndex becomes set unexpectedly after exiting edit mode. 10 11 * inspector/front-end/UIUtils.js: 12 (WebInspector.startEditing.cleanUpAfterEditing): 13 1 14 2012-03-27 Vsevolod Vlasov <vsevik@chromium.org> 2 15 -
trunk/Source/WebCore/inspector/front-end/UIUtils.js
r111551 r112257 281 281 element.addStyleClass("editing"); 282 282 283 var oldTabIndex = element. tabIndex;284 if ( element.tabIndex < 0)283 var oldTabIndex = element.getAttribute("tabIndex"); 284 if (isNaN(oldTabIndex) || oldTabIndex < 0) 285 285 element.tabIndex = 0; 286 286 … … 302 302 303 303 this.removeStyleClass("editing"); 304 this.tabIndex = oldTabIndex; 304 305 if (isNaN(oldTabIndex)) 306 element.removeAttribute("tabIndex"); 307 else 308 this.tabIndex = oldTabIndex; 305 309 this.scrollTop = 0; 306 310 this.scrollLeft = 0;
Note: See TracChangeset
for help on using the changeset viewer.