Changeset 112262 in webkit

Timestamp:

Mar 27, 2012 7:23:22 AM (12 years ago)

Author:

yurys@chromium.org

Message:

Web Inspector: Fix missing objects in the dominators view.
​https://bugs.webkit.org/show_bug.cgi?id=82194

Due to the nature of dominators tree it is not possible to hide internal
objects there because they may happen to contain user objects that can't
be hidden.
Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
function.

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-03-27
Reviewed by Yury Semikhatsky.

Source/WebCore:

• inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):

• inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotArraySlice.prototype.slice):

LayoutTests:

• inspector/profiler/heap-snapshot-expected.txt:
• inspector/profiler/heap-snapshot.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/profiler/heap-snapshot-expected.txt (modified) (1 diff)
• LayoutTests/inspector/profiler/heap-snapshot.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js (modified) (2 diffs)
• Source/WebCore/inspector/front-end/HeapSnapshot.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-27  Alexei Filippov  <alexeif@chromium.org>
+
+        Web Inspector: Fix missing objects in the dominators view.
+        https://bugs.webkit.org/show_bug.cgi?id=82194
+
+        Due to the nature of dominators tree it is not possible to hide internal
+        objects there because they may happen to contain user objects that can't
+        be hidden.
+        Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
+        function.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/profiler/heap-snapshot-expected.txt:
+        * inspector/profiler/heap-snapshot.html:
+
 2012-03-27  Alexis Menard  <alexis.menard@openbossa.org>
 

trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt

@@ -20 +20 @@
 Running: heapSnapshotFlagsTest
 
+Running: heapSnapshotArraySliceTest
+
 Running: heapSnapshotNodesProviderTest
 

trunk/LayoutTests/inspector/profiler/heap-snapshot.html

@@ -173 +173 @@
         },
 
+        function heapSnapshotArraySliceTest(next)
+        {
+            var snapshot = new WebInspector.HeapSnapshot(InspectorTest.createHeapSnapshotMock());
+            var root = snapshot.rootNode;
+            var rawEdges = root.rawEdges;
+            InspectorTest.assertEquals(6, rawEdges.length);
+            InspectorTest.assertEquals(6, rawEdges.slice(0).length);
+            InspectorTest.assertEquals(3, rawEdges.slice(3).length);
+            InspectorTest.assertEquals(3, rawEdges.slice(3, 6).length);
+            InspectorTest.assertEquals(3, rawEdges.slice(0, 3).length);
+            InspectorTest.assertEquals(0, rawEdges.slice(3, 3).length);
+            next();
+        },
+
         function heapSnapshotNodesProviderTest(next)
         {

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Alexei Filippov  <alexeif@chromium.org>
+
+        Web Inspector: Fix missing objects in the dominators view.
+        https://bugs.webkit.org/show_bug.cgi?id=82194
+
+        Due to the nature of dominators tree it is not possible to hide internal
+        objects there because they may happen to contain user objects that can't
+        be hidden.
+        Besides that it fixes a small bug in HeapSnapshotArraySlice.slice
+        function.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/DetailedHeapshotGridNodes.js:
+        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
+        * inspector/front-end/HeapSnapshot.js:
+        (WebInspector.HeapSnapshotArraySlice.prototype.slice):
+
 2012-03-27  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js

@@ -504 +504 @@
     _createProvider: function(snapshot, nodeIndex)
     {
-        var showHiddenData = WebInspector.DetailedHeapshotView.prototype.showHiddenData;
+        var showHiddenData = WebInspector.settings.showHeapSnapshotObjectsHiddenProperties.get();
         return snapshot.createEdgesProvider(
             nodeIndex,
@@ -837 +837 @@
     _createProvider: function(snapshot, nodeIndex)
     {
-        var showHiddenData = WebInspector.DetailedHeapshotView.prototype.showHiddenData;
         return snapshot.createNodesProviderForDominator(nodeIndex,
-            "function (node) {" +
-            "     return " + showHiddenData + " || !node.isHidden;" +
-            "}");
+            "function (node) { return true; }");
     },
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js

@@ -231 +231 @@
     {
         if (typeof end === "undefined")
-            end = start + this._start + this.length;
-        return this._snapshot[this._arrayName].subarray(this._start + start, end);
+            end = this.length;
+        return this._snapshot[this._arrayName].subarray(this._start + start, this._start + end);
     }
 }