Changeset 112267 in webkit

Timestamp:

Mar 27, 2012 7:51:03 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Tabbed pane should set focus on its contents on tab click.
​https://bugs.webkit.org/show_bug.cgi?id=82323

Reviewed by Pavel Feldman.

Otherwise selected tab does not have focus.
Also added tabIndex on tabElements to prevent pasting on closing middle click.

• inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.focus):
(WebInspector.TabbedPane.prototype.selectTab):
(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabClicked):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TabbedPane.js (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Tabbed pane should set focus on its contents on tab click.
+        https://bugs.webkit.org/show_bug.cgi?id=82323
+
+        Reviewed by Pavel Feldman.
+
+        Otherwise selected tab does not have focus.
+        Also added tabIndex on tabElements to prevent pasting on closing middle click.
+
+        * inspector/front-end/TabbedPane.js:
+        (WebInspector.TabbedPane):
+        (WebInspector.TabbedPane.prototype.focus):
+        (WebInspector.TabbedPane.prototype.selectTab):
+        (WebInspector.TabbedPaneTab.prototype._createTabElement):
+        (WebInspector.TabbedPaneTab.prototype._tabClicked):
+
 2012-03-27  Pavel Podivilov  <podivilov@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TabbedPane.js

@@ -87 +87 @@
     },
 
+    focus: function()
+    {
+        if (!this.visibleView)
+            return;
+        if (typeof(this.visibleView.focus) === "function")
+            this.visibleView.focus();
+        else
+            this.visibleView.element.focus();
+    },
+
     /**
      * @param {string} id
@@ -173 +183 @@
         
         this._updateTabElements();
-        
+
         var eventData = { tabId: id, view: tab.view, isUserGesture: userGesture };
         this.dispatchEventToListeners(WebInspector.TabbedPane.EventTypes.TabSelected, eventData);
@@ -589 +599 @@
         var tabElement = document.createElement("div");
         tabElement.addStyleClass("tabbed-pane-header-tab");
+        tabElement.tabIndex = -1;
         
         var titleElement = tabElement.createChild("span", "tabbed-pane-header-tab-title");
@@ -628 +639 @@
         else
             this._tabbedPane.selectTab(this.id, true);
+        this._tabbedPane.focus();
     }
 }