Changeset 112289 in webkit

Timestamp:

Mar 27, 2012 11:42:02 AM (12 years ago)

Author:

andersca@apple.com

Message:

Don't update the layer hosting state unless the WKView is added to a window
​https://bugs.webkit.org/show_bug.cgi?id=82359

Reviewed by Sam Weinig.

This avoids thrashing the layer hosting state when switching tabs.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewStateDidChange):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-03-27  Anders Carlsson  <andersca@apple.com>
+
+        Don't update the layer hosting state unless the WKView is added to a window
+        https://bugs.webkit.org/show_bug.cgi?id=82359
+
+        Reviewed by Sam Weinig.
+
+        This avoids thrashing the layer hosting state when switching tabs.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::viewStateDidChange):
+
 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -779 +779 @@
         }
 
-        LayerHostingMode layerHostingMode = m_pageClient->viewLayerHostingMode();
-        if (m_layerHostingMode != layerHostingMode) {
-            m_layerHostingMode = layerHostingMode;
-            m_drawingArea->layerHostingModeDidChange();
+        if (isInWindow) {
+            LayerHostingMode layerHostingMode = m_pageClient->viewLayerHostingMode();
+            if (m_layerHostingMode != layerHostingMode) {
+                m_layerHostingMode = layerHostingMode;
+                m_drawingArea->layerHostingModeDidChange();
+            }
         }
     }