Changeset 112336 in webkit

Timestamp:

Mar 27, 2012 5:12:30 PM (12 years ago)

Author:

macpherson@chromium.org

Message:

Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
​https://bugs.webkit.org/show_bug.cgi?id=82393

Reviewed by Eric Seidel.

No new tests / adding assetions only.

• css/LengthFunctions.cpp:

(WebCore::valueForLength):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/LengthFunctions.cpp (modified) (1 diff)
• rendering/RenderBox.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Luke Macpherson  <macpherson@chromium.org>
+
+        Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging.
+        https://bugs.webkit.org/show_bug.cgi?id=82393
+
+        Reviewed by Eric Seidel.
+
+        No new tests / adding assetions only.
+
+        * css/LengthFunctions.cpp:
+        (WebCore::valueForLength):
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::computeLogicalWidthInRegionUsing):
+
 2012-03-27  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebCore/css/LengthFunctions.cpp

@@ -81 +81 @@
     case Auto:
         return maximumValue;
+    // multiple assertions are used below to provide more useful debug output.
     case Relative:
+        ASSERT_NOT_REACHED();
     case Intrinsic:
+        ASSERT_NOT_REACHED();
     case MinIntrinsic:
+        ASSERT_NOT_REACHED();
     case Undefined:
         ASSERT_NOT_REACHED();

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -1845 +1845 @@
     else
         logicalWidth = styleToUse->logicalMaxWidth();
+
+    ASSERT(!logicalWidth.isUndefined());
 
     if (logicalWidth.isIntrinsicOrAuto()) {