Changeset 112341 in webkit

Timestamp:

Mar 27, 2012 5:27:27 PM (12 years ago)

Author:

alexis.menard@openbossa.org

Message:

Simplify CSSPropertyBorderSpacing parsing.
​https://bugs.webkit.org/show_bug.cgi?id=82397

Reviewed by Benjamin Poulain.

Remove the local array of longhand properties as it doesn't really
bring much in this simple parsing algorithm.

No new tests, no functionality change intended.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Alexis Menard  <alexis.menard@openbossa.org>
+
+        Simplify CSSPropertyBorderSpacing parsing.
+        https://bugs.webkit.org/show_bug.cgi?id=82397
+
+        Reviewed by Benjamin Poulain.
+
+        Remove the local array of longhand properties as it doesn't really
+        bring much in this simple parsing algorithm.
+
+        No new tests, no functionality change intended.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseValue):
+
 2012-03-27  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -1539 +1539 @@
 
     case CSSPropertyBorderSpacing: {
-        const int properties[2] = { CSSPropertyWebkitBorderHorizontalSpacing,
-                                    CSSPropertyWebkitBorderVerticalSpacing };
         if (num == 1) {
             ShorthandScope scope(this, CSSPropertyBorderSpacing);
-            if (!parseValue(properties[0], important))
+            if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important))
                 return false;
             CSSValue* value = m_parsedProperties.last().value();
-            addProperty(properties[1], value, important);
+            addProperty(CSSPropertyWebkitBorderVerticalSpacing, value, important);
             return true;
         }
         else if (num == 2) {
             ShorthandScope scope(this, CSSPropertyBorderSpacing);
-            if (!parseValue(properties[0], important) || !parseValue(properties[1], important))
+            if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important) || !parseValue(CSSPropertyWebkitBorderVerticalSpacing, important))
                 return false;
             return true;