Changeset 112343 in webkit

Timestamp:

Mar 27, 2012 5:37:41 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Coverity] Address some uninitialized constructor values.
​https://bugs.webkit.org/show_bug.cgi?id=82376

Patch by Kausalya Madhusudhanan <​kmadhusu@chromium.org> on 2012-03-27
Reviewed by James Robinson.

Source/WebCore:

New tests are not required since I did not modify any code behavior.

• html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):

• inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

• platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):

• platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::DataTransferItemChromium):

• platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

• storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):

Source/WebKit/chromium:

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

• src/WebCompositorInputHandlerImpl.cpp:

(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/shadow/MediaControlRootElementChromium.cpp (modified) (1 diff)
• WebCore/inspector/InspectorIndexedDBAgent.h (modified) (1 diff)
• WebCore/inspector/InspectorTimelineAgent.cpp (modified) (1 diff)
• WebCore/page/scrolling/ScrollingCoordinator.cpp (modified) (1 diff)
• WebCore/platform/ScrollAnimatorNone.cpp (modified) (1 diff)
• WebCore/platform/chromium/DataTransferItemChromium.cpp (modified) (1 diff)
• WebCore/platform/graphics/skia/ImageBufferSkia.cpp (modified) (1 diff)
• WebCore/storage/StorageTask.cpp (modified) (3 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-27  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
+
+        [Coverity] Address some uninitialized constructor values.
+        https://bugs.webkit.org/show_bug.cgi?id=82376
+
+        Reviewed by James Robinson.
+
+        New tests are not required since I did not modify any code behavior.
+
+        * html/shadow/MediaControlRootElementChromium.cpp:
+        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+        * inspector/InspectorIndexedDBAgent.h:
+        (InspectorIndexedDBAgent):
+        * inspector/InspectorTimelineAgent.cpp:
+        (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::ScrollingCoordinator):
+        * platform/ScrollAnimatorNone.cpp:
+        (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
+        * platform/chromium/DataTransferItemChromium.cpp:
+        (WebCore::DataTransferItemChromium::DataTransferItemChromium):
+        * platform/graphics/skia/ImageBufferSkia.cpp:
+        (WebCore::ImageBuffer::ImageBuffer):
+        * storage/StorageTask.cpp:
+        (WebCore::StorageTask::StorageTask):
+
 2012-03-27  Alexis Menard  <alexis.menard@openbossa.org>
 

trunk/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp

@@ -59 +59 @@
 #if ENABLE(VIDEO_TRACK)
     , m_textDisplayContainer(0)
+    , m_textTrackDisplay(0)
 #endif
     , m_opaque(true)

trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.h

@@ -71 +71 @@
     InspectorPageAgent* m_pageAgent;
     RefPtr<FrontendProvider> m_frontendProvider;
-    bool m_enabled;
 };
 

trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp

@@ -437 +437 @@
     : InspectorBaseAgent<InspectorTimelineAgent>("Timeline", instrumentingAgents, state)
     , m_frontend(0)
+    , m_timestampOffset(0)
     , m_id(1)
     , m_maxCallStackDepth(5)

trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -61 +61 @@
     , m_scrollingTreeStateCommitterTimer(this, &ScrollingCoordinator::scrollingTreeStateCommitterTimerFired)
 #endif
+    , m_private(0)
 {
 }

trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp

@@ -381 +381 @@
     , m_horizontalData(this, &m_currentPosX, scrollableArea->visibleWidth())
     , m_verticalData(this, &m_currentPosY, scrollableArea->visibleHeight())
+    , m_startTime(0)
     , m_animationActive(false)
     , m_firstVelocity(0)

trunk/Source/WebCore/platform/chromium/DataTransferItemChromium.cpp

@@ -96 +96 @@
     , m_kind(kind)
     , m_type(type)
+    , m_sequenceNumber(0)
 {
 }

trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp

@@ -128 +128 @@
     : m_data(size)
     , m_size(size)
+    , m_resolutionScale(1)
 {
     OwnPtr<SkCanvas> canvas;

trunk/Source/WebCore/storage/StorageTask.cpp

@@ -53 +53 @@
 StorageTask::StorageTask(Type type)
     : m_type(type)
+    , m_area(0)
+    , m_thread(0)
 {
     ASSERT(m_type == ImportOrigins || m_type == DeleteAllOrigins);
@@ -59 +61 @@
 StorageTask::StorageTask(Type type, const String& originIdentifier)
     : m_type(type)
+    , m_area(0)
+    , m_thread(0)
     , m_originIdentifier(originIdentifier)
 {
@@ -66 +70 @@
 StorageTask::StorageTask(Type type, const String& originIdentifier, const String& databaseFilename)
     : m_type(type)
+    , m_area(0)
+    , m_thread(0)
     , m_originIdentifier(originIdentifier)
     , m_databaseFilename(databaseFilename)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-03-27  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
+
+        [Coverity] Address some uninitialized constructor values.
+        https://bugs.webkit.org/show_bug.cgi?id=82376
+
+        Reviewed by James Robinson.
+
+        New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.
+
+        * src/WebCompositorInputHandlerImpl.cpp:
+        (WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
+
 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp

@@ -77 +77 @@
     PlatformGestureToCCGestureAdapter(PassOwnPtr<PlatformGestureCurve> curve)
         : m_curve(curve)
+        , m_target(0)
     {
     }