Changeset 112351 in webkit

Timestamp:

Mar 27, 2012 6:56:30 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
​https://bugs.webkit.org/show_bug.cgi?id=82381

Patch by James Robinson <​jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

Use the mock scrollbar theme for this unit test. The real ScrollbarThemeMac isn't compatible with the mocks this
test uses and the test isn't designed to cover the theming code, only code inside the compositor.

• tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• tests/ScrollbarLayerChromiumTest.cpp (modified) (2 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2012-03-27  James Robinson  <jamesr@chromium.org>
+
+        webkit_unit_tests crashing on chromium lion in ScrollbarLayerChromiumTest.resolveScrollLayerPointer
+        https://bugs.webkit.org/show_bug.cgi?id=82381
+
+        Reviewed by Adrienne Walker.
+
+        Use the mock scrollbar theme for this unit test. The real ScrollbarThemeMac isn't compatible with the mocks this
+        test uses and the test isn't designed to cover the theming code, only code inside the compositor.
+
+        * tests/ScrollbarLayerChromiumTest.cpp:
+        (WebCore::TEST):
+
 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp

@@ -28 +28 @@
 
 #include "Scrollbar.h"
+#include "Settings.h"
 #include "TreeSynchronizer.h"
 #include "cc/CCScrollbarLayerImpl.h"
@@ -91 +92 @@
     DebugScopedSetImplThread impl;
 
+    Settings::setMockScrollbarsEnabled(true);
     {
         RefPtr<MockScrollbar> scrollbar = adoptRef(new MockScrollbar);