Changeset 112395 in webkit

Timestamp:

Mar 28, 2012 7:37:56 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

window.scrollBy() scrolls incorrectly when zoomed in/out
​https://bugs.webkit.org/show_bug.cgi?id=45228

Patch by Eugene Girard <​girard@chromium.org> on 2012-03-28
Reviewed by Simon Fraser.

scrollBy now uses layout (not CSS) units. (As scrollTo does.)

Source/WebCore:

Test: fast/dom/zoom-scroll-page-test.html

• page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollBy):

LayoutTests:

• fast/dom/zoom-scroll-page-test-expected.txt: Added.
• fast/dom/zoom-scroll-page-test.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/zoom-scroll-page-test-expected.txt (added)
• LayoutTests/fast/dom/zoom-scroll-page-test.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/DOMWindow.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-03-28  Eugene Girard  <girard@chromium.org>
+
+        window.scrollBy() scrolls incorrectly when zoomed in/out
+        https://bugs.webkit.org/show_bug.cgi?id=45228
+
+        Reviewed by Simon Fraser.
+
+        scrollBy now uses layout (not CSS) units. (As scrollTo does.)
+
+        * fast/dom/zoom-scroll-page-test-expected.txt: Added.
+        * fast/dom/zoom-scroll-page-test.html: Added.
+
 2012-03-28  Stephen Chenney  <schenney@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-28  Eugene Girard  <girard@chromium.org>
+
+        window.scrollBy() scrolls incorrectly when zoomed in/out
+        https://bugs.webkit.org/show_bug.cgi?id=45228
+
+        Reviewed by Simon Fraser.
+
+        scrollBy now uses layout (not CSS) units. (As scrollTo does.)
+
+        Test: fast/dom/zoom-scroll-page-test.html
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::scrollBy):
+
 2012-03-28  Stephen Chenney  <schenney@chromium.org>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -1350 +1350 @@
         return;
 
-    view->scrollBy(IntSize(x, y));
+    IntSize scaledOffset(view->mapFromCSSToLayoutUnits(x), view->mapFromCSSToLayoutUnits(y));
+    view->scrollBy(scaledOffset);
 }