Changeset 112413 in webkit

Timestamp:

Mar 28, 2012 11:08:04 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: ScriptsNavigator should save scroll position when switching tabs.
​https://bugs.webkit.org/show_bug.cgi?id=82472

Reviewed by Pavel Feldman.

WebInspector.View provides save/restore scroll position capabilities.
This patch makes them used in ScriptsNavigator.

• inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._createSnippetsTree):

• inspector/front-end/scriptsPanel.css:

(#scripts-navigator-tabbed-pane .tabbed-pane-content):
(#scripts-navigator-tabbed-pane .navigator-container):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ScriptsNavigator.js (modified) (5 diffs)
• inspector/front-end/scriptsPanel.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-03-28  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: ScriptsNavigator should save scroll position when switching tabs.
+        https://bugs.webkit.org/show_bug.cgi?id=82472
+
+        Reviewed by Pavel Feldman.
+
+        WebInspector.View provides save/restore scroll position capabilities.
+        This patch makes them used in ScriptsNavigator.
+
+        * inspector/front-end/ScriptsNavigator.js:
+        (WebInspector.ScriptsNavigator):
+        (WebInspector.ScriptsNavigator.prototype._createSnippetsTree):
+        * inspector/front-end/scriptsPanel.css:
+        (#scripts-navigator-tabbed-pane .tabbed-pane-content):
+        (#scripts-navigator-tabbed-pane .navigator-container):
+
 2012-03-28  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ScriptsNavigator.js

@@ -50 +50 @@
     var scriptsTreeElement = document.createElement("ol");
     var scriptsView = new WebInspector.View();
-    scriptsView.element.addStyleClass("outline-disclosure");
-    scriptsView.element.addStyleClass("navigator");
-    scriptsView.element.appendChild(scriptsTreeElement);
+    scriptsView.element.addStyleClass("fill");
+    scriptsView.element.addStyleClass("navigator-container");
+    var scriptsOutlineElement = document.createElement("div");
+    scriptsOutlineElement.addStyleClass("outline-disclosure");
+    scriptsOutlineElement.addStyleClass("navigator");
+    scriptsOutlineElement.appendChild(scriptsTreeElement);
+    scriptsView.element.appendChild(scriptsOutlineElement);
     this._scriptsTree = new WebInspector.NavigatorTreeOutline(this, scriptsTreeElement);
     this._tabbedPane.appendTab(WebInspector.ScriptsNavigator.ScriptsTab, WebInspector.UIString("Scripts"), scriptsView);
@@ -59 +63 @@
     var contentScriptsTreeElement = document.createElement("ol");
     var contentScriptsView = new WebInspector.View();
-    contentScriptsView.element.addStyleClass("outline-disclosure");
-    contentScriptsView.element.addStyleClass("navigator");
-    contentScriptsView.element.appendChild(contentScriptsTreeElement);
+    contentScriptsView.element.addStyleClass("fill");
+    contentScriptsView.element.addStyleClass("navigator-container");
+    var contentScriptsOutlineElement = document.createElement("div");
+    contentScriptsOutlineElement.addStyleClass("outline-disclosure");
+    contentScriptsOutlineElement.addStyleClass("navigator");
+    contentScriptsOutlineElement.appendChild(contentScriptsTreeElement);
     this._contentScriptsTree = new WebInspector.NavigatorTreeOutline(this, contentScriptsTreeElement);
     this._tabbedPane.appendTab(WebInspector.ScriptsNavigator.ContentScriptsTab, WebInspector.UIString("Content scripts"), contentScriptsView);
 
-    var snippetsTreeElement = document.createElement("ol");
-    var snippetsView = new WebInspector.View();
-    snippetsView.element.addStyleClass("outline-disclosure");
-    snippetsView.element.addStyleClass("navigator");
-    snippetsView.element.appendChild(snippetsTreeElement);
-    this._snippetsTree = new WebInspector.NavigatorTreeOutline(this, snippetsTreeElement);
-    if (WebInspector.experimentsSettings.snippetsSupport.isEnabled())
-        this._tabbedPane.appendTab(WebInspector.ScriptsNavigator.SnippetsTab, WebInspector.UIString("Snippets"), snippetsView);
+    this._snippetsTree = this._createSnippetsTree();
 
     this._folderTreeElements = {};
@@ -260 +260 @@
     },
     
+    _createSnippetsTree: function()
+    {
+        var snippetsTreeElement = document.createElement("ol");
+        var snippetsView = new WebInspector.View();
+        snippetsView.element.addStyleClass("fill");
+        snippetsView.element.addStyleClass("navigator-container");
+        var snippetsOutlineElement = document.createElement("div");
+        snippetsOutlineElement.addStyleClass("outline-disclosure");
+        snippetsOutlineElement.addStyleClass("navigator");
+        snippetsOutlineElement.appendChild(snippetsTreeElement);
+        snippetsView.element.appendChild(snippetsOutlineElement);
+        var snippetsTree = new WebInspector.NavigatorTreeOutline(this, snippetsTreeElement);
+        if (WebInspector.experimentsSettings.snippetsSupport.isEnabled())
+            this._tabbedPane.appendTab(WebInspector.ScriptsNavigator.SnippetsTab, WebInspector.UIString("Snippets"), snippetsView);
+        return snippetsTree;
+    },
+
+
     reset: function()
     {
@@ -316 +334 @@
         return contentScriptPrefix + ":" + domain + folderName;
     },
-    
+
     /**
      * @param {boolean} isContentScript
@@ -349 +367 @@
  * @constructor
  * @extends {TreeOutline}
+ * @param {WebInspector.ScriptsNavigator} navigator
  * @param {Element} element
  */

trunk/Source/WebCore/inspector/front-end/scriptsPanel.css

@@ -248 +248 @@
 }
 
+#scripts-navigator-tabbed-pane .tabbed-pane-content {
+    overflow: hidden;
+}
+
+#scripts-navigator-tabbed-pane .navigator-container {
+    overflow-y: auto;
+    overflow-x: hidden;
+}
+
 #scripts-navigator-tabbed-pane .navigator {
     padding-left: 0;